Remove some DeviceTracking namespace classes#5491
Merged
zachmargolis merged 11 commits intomainfrom Oct 12, 2021
Merged
Conversation
zachmargolis
requested review from
aduth,
jmhooper,
mitchellhenke and
stevegsa
zachmargolis
commented
Oct 8, 2021
app/services/forget_all_browsers.rb
Outdated
Contributor
Author
There was a problem hiding this comment.
this was just de-namespaced/moved
zachmargolis
force-pushed
the
margolis-devicetracking-namespace
branch
from
22b8ed2 to
e1adcb7
Compare
mitchellhenke
approved these changes
Oct 8, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While discovering #5489, I found this "class cluster" in our older style of one-method per class. These are usually pretty trivial classes that I think work better by being inlined, especially since the ones with complex logic are only really used in one place
ForgetAllBrowserswhich is an action, and so I just removed it from the namespace, since it didn't quite fit