Merged
Conversation
**Why**: Because class properties are now part of the ES2022 specification, it is no longer necessary to use a plugin to support the syntax.
* Run ERBLint on ViewComponent markup **Why**: Because these ERB files live outside app/views, but should still be subject to linting. * Split paths passed to ERBLint Seems expansion support may be OS/shell-specific
**Why**: So all new code is type-checked by default, saving us the risk / effort of opting-in.
* allow "bots" to log events * Add separate error for token expiration * set expiration in initialize * translate errors
- Seems to be updated more recently than DeviceDetector - See JIRA, examples of mobile being detected incorrectly - With a cache layer, performs similarly * Use an LRU cache for browser parsing + caching
* Remove separate methods * Mac OS X => macOS
* Remove DeviceTracking::DeviceName
* Remove DeviceTracking::ListDevices
* Remove DeviceTracking::UpdateDevice, move to Device
* Remove DeviceTracking::LookupDeviceForUser
* Remove DeviceTracking::CreateDevice
* Remove DeviceTracking::ListDeviceEvents
* Rename {DeviceTracking => }ForgetAllBrowsers
Bumps [puma](https://github.com/puma/puma) from 5.3.2 to 5.5.1. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v5.3.2...v5.5.1) --- updated-dependencies: - dependency-name: puma dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add checkmark to success message * add solid border to successful upload status
* Move pending_profile from UserDecorator down to User * Remove Idv::ProfileActivator class
aduth
approved these changes
Oct 14, 2021
zachmargolis
approved these changes
Oct 14, 2021
config/country_dialing_codes.yml
Outdated
| country_code: '670' | ||
| name: Timor-Leste | ||
| supports_sms: true | ||
| supports_sms: false |
Contributor
There was a problem hiding this comment.
this shouldn't be in the diff... it should already be false in prod since we did a patch release
identity-idp/config/locales/user_mailer/en.yml
Lines 195 to 198 in 0544a36
maybe we need to do a merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.