Fix local file changes on "make normalize_yaml"#5028
Closed
Conversation
zachmargolis
reviewed
May 6, 2021
zachmargolis
reviewed
May 6, 2021
Contributor
Author
|
Update: I was having trouble last week with CircleCI vs. locally behaving differently. In the meantime, I discovered a fix for the issue I'd had with getting the JavaScript/Prettier reimplementation to sort keys, so I may explore that route again to both circumvent the CircleCI issues and actually support comments in the YAML. Hoping to revisit this week, but considering it as lower priority than other tasks. |
**Why**: So there's no inconsistency between local environments and CircleCI test results
**Why**: Differences in behavior of normalize_yaml seem to be associated with a bug in libyaml which is expected to have been resolved in 0.2.5. Maybe the new pre-built images have it.
**Why**: Bundled with Ruby See: GSA-TTS/identity-site#628 (comment)
**Why**: To get new features and bug fixes, and to avoid needing to work around this in CI to manually downgrade to an older version.
Resolve CircleCI error "make: i18n-tasks: Command not found"
**Why**: Errors seen previously were likely caused by issue fixed in 776a9fa8e
Causing errors in CircleCI "cannot load such file". Ideally we'd diagnose why those errors are happening, but AFAICT the dependency isn't used anyways?
**Why**: Should always go through the Makefile script, which includes additional formatting passes
aduth
force-pushed
the
aduth-normalize-yaml-avoid-local-changes
branch
from
061ffbc to
df0c06c
Compare
**Why**: To make bundler gems available to script See: https://bundler.io/v2.1/guides/bundler_setup.html#setting-up-your-application-to-use-bundler
Contributor
Author
|
Closing in favor of #5066 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To prevent accidental changes, to bring CircleCI build and local development into stricter alignment, to ensure that
make normalize_yamlactually normalizes the way that we'd expect it to, and to expand test coverage for YAML normalization to cover all files formatted by the Make target.Initially I'd planned for the
month_nameschange to setnullas the first entry, but it appears thatYAML.dumpformats this back to the empty entry. Not sure if this produces inconsistent results in other environments.If we want to retain the comments in
country_dialing_codes.yml, would there be a reasonable alternative place to put them? Or would it suffice to referencegit blameto recall the reason for a setting?