Detect duplicate keys in frontmatter YAML#628
Merged
zachmargolis merged 3 commits intomainfrom Apr 29, 2021
Merged
Conversation
aduth
reviewed
Apr 29, 2021
| duplicate_keys = [] | ||
|
|
||
| validator = ->(node, parent_path) do | ||
| if node.is_a?(Psych::Nodes::Mapping) |
Contributor
There was a problem hiding this comment.
Should we add psych to Gemfile so that we're not relying on a transitive dependency?
Contributor
Author
There was a problem hiding this comment.
The built-in ruby parser is psych these days, so I think it's fine as-is?
irb(main):001:0> defined?(Psych)
=> nil
irb(main):002:0> require 'yaml'
=> true
irb(main):003:0> defined?(Psych)
=> "constant"
Contributor
There was a problem hiding this comment.
The built-in ruby parser is psych these days, so I think it's fine as-is?
irb(main):001:0> defined?(Psych) => nil irb(main):002:0> require 'yaml' => true irb(main):003:0> defined?(Psych) => "constant"
Ah, I didn't know that, was primarily going by...
Seems fine.
Contributor
Author
There was a problem hiding this comment.
FWIW the other place we use it isn't the IDP, it's the idp-config repo which doesn't have psych in its Gemfile either
jmdembe
approved these changes
Apr 29, 2021
aduth
added a commit
to 18F/identity-idp
that referenced
this pull request
May 13, 2021
**Why**: Bundled with Ruby See: GSA-TTS/identity-site#628 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.