Rubocop multiline method calls

[mitchellhenke]

Based on the conversation here: #4876 (comment)

Goal is to require this:

      @register_user_email_form = RegisterUserEmailForm.new(
        recaptcha_results: validate_recaptcha,
        analytics: analytics,
      )

Instead of allowing this:

      user, result = RequestPasswordReset.new(email: email,
                                              request_id: request_id,
                                              analytics: analytics).perform

The rule changes required to get that resulted in some other alignment and spacing fixes

[zachmargolis]

LGTM big fan

[aduth]

Nice 👍

[aduth]

Just curious, would the following be an error?

Suggested change

	params.require(:resolution_result).permit(
	:exception, :success, :timed_out, :transaction_id,
	errors: {}, context: {}
	)
	params.require(:resolution_result).permit(
	:exception,
	:success,
	:timed_out,
	:transaction_id,
	errors: {},
	context: {},
	)

[mitchellhenke]

I don't take any issues with it as-is. I would maybe consider splitting it up into an array that gets passed into the function (if it accepts it in that form)

permitted_params = [:exception, :success, :timed_out, :transaction_id, errors: {}, context: {}]
params.require(:resolution_result).permit(permitted_params)