Merged
Conversation
**Why**: Consistency with other labels
**Why**: Consistent text with other MFA options
**Why**: Avoid inappropriate use of heading styles, and ensure consistency across links
**Why**: All images should have an alternative text, even if empty for decorative images
**Why**: Since the margin will be the same for small and large viewport displays, it can be set once using the unprefixed class.
**Why**: Because these are two independent sentences.
**Why**: Design choice. Previously we had implemented ad hoc adjustments to achieve this effect based on design mockups, particularly in alerts for document capture and SSN steps in the IAL2 flow.
**Why**: To appear more in line with other warning screens that the user may see in this flow.
**Why**: So that page elements aren't bumping into each other as much.
**Why**: Minimize use of utility classes and inherit default typographical spacing (to be further improved later)
**Why**: So that the header elements correctly appear as vertically centered
**Why**: Avoid bumping with preceding element when shown as error, since it's expected the form group would handle the margin.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@anniehirshman-gsa and I spent some time yesterday morning pairing to discover and resolve a number of minor styling blemishes throughout the application. These are changes which on their own wouldn't warrant a dedicated ticket, but which may reflect poorly in the user's experience.
There's a bunch of changes here, some of which are larger than others. I'm happy to split this up into a few smaller pull requests if it's easier to review.
Screenshots:
Use consistent separator styles for colored horizontal rule (13f911b)
Remove serif style from fieldset legend (f8464d0)
Remove inconsistent "other option" label for backup code MFA (4aa8deb)
Remove H5 styling from Cancel links (df1ac49)
Add missing period in GPO alternative option text (66a68e0)
Increase default mobile container padding (f9eb874)
Improve consistency of IAL2 cancellation screens (f7e86b5)
Increase spacing on review step (bcc120c)
Increase spacing on "Add Phone" screens (6ab7c14)
Fix header excess spacing (f1bcd8c)
Set form group override styles to preserve label margin (0a83b20)