-
Notifications
You must be signed in to change notification settings - Fork 166
LG-4052: updated translations #4879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,7 +114,7 @@ en: | |
| sign in</strong>. | ||
| phone_voice_label: Phone number | ||
| piv_cac_fallback: | ||
| question: Don't have your piv/cac card available? | ||
| question: Don't have your PIV or CAC available? | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to confirm, these strings aren't for IAL2. PIV/CAC verification was removed as of #4819. The updated texts read as an improvement to me all the same, so I think they'd be fine, but wanted to double-check. |
||
| piv_cac_header_text: Present your PIV/CAC | ||
| piv_cac_webauthn_available: Use your security key | ||
| please_try_again_html: Please try again in <strong id=%{id}>%{time_remaining}</strong>. | ||
|
|
@@ -163,7 +163,7 @@ en: | |
| webauthn_fallback: | ||
| question: Don't have your security key available? | ||
| webauthn_header_text: Connect your security key | ||
| webauthn_piv_available: Use your government employee ID | ||
| webauthn_piv_available: Use your PIV or CAC | ||
| webauthn_verified: | ||
| header: Security key verified | ||
| info: We have verified your security key. Click continue to sign in. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something possibly worth following-up on: We're not always consistent with our use of Oxford comma. There's very similar error messages where we omit it (e.g. "Must be a JPG, BMP, PNG or TIFF", translated as "Debe ser un JPG, BMP, PNG o TIFF").
Since this is correct per our own English text and translation, I don't think it's a blocker.