Consolidate identity methods into one class#4733
Merged
mitchellhenke merged 2 commits intomasterfrom Mar 1, 2021
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/consolidate-identity-methods
branch
from
9d1cdb4 to
cf1af66
Compare
zachmargolis
approved these changes
Mar 1, 2021
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
I'm not convinced this class needs to go away, but the changes LGTM
Contributor
There was a problem hiding this comment.
This is a bummer IMO, seems weird that we mix decorated and not-decorated objects. Would you want to remove those other decorators as well, or just the identity one?
Contributor
Author
There was a problem hiding this comment.
I'd be fine removing the other ones too, but I'm less familiar with them. In this case pretty much every usage of Identity was decorated, and it even overloaded the created_at method.
This part was a bit odd to me at first, but it doesn't feel much weirder than putting two pretty distinct types of objects in an array. As long as they respond to the methods that they need to?
mitchellhenke
force-pushed
the
mitchellhenke/consolidate-identity-methods
branch
from
4d096a0 to
5e9d565
Compare
mitchellhenke
changed the title
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4728 to remove the
IdentityDecorator