Merged
Conversation
**Why**: This frees up the Identity:: namespace to be a module so our gems can use it and match their "identity-" project names.
| @@ -1,3 +1,4 @@ | |||
| # Null object pattern substitute for ServiceProviderIdentity | |||
Contributor
There was a problem hiding this comment.
Should this be renamed to NullServiceProviderIdentity?
Contributor
Author
There was a problem hiding this comment.
I could go both ways....since there is no service provider... it's just a null identity?
How strongly do you feel?
Contributor
There was a problem hiding this comment.
Not very, the comment makes it clear enough
mitchellhenke
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: This frees up the Identity:: namespace to be a
module so our gems can use it and match their "identity-"
project names.
self.table_name =ServiceProviderIdentityseemed like the simples thing that kind of explained how this is a join between users and service providers