LG-4099: Don't allow any /verify/* path in prod without SP context #4634
Merged
LG-4099: Don't allow any /verify/* path in prod without SP context #4634
Conversation
…lly work?" Correctly use the have_action matcher This reverts commit 2e3fae7.
zachmargolis
reviewed
Feb 1, 2021
jmhooper
added a commit
that referenced
this pull request
Nov 27, 2023
In #4634 we restricted the identity verification process to require a service provider for a user to undergo proofing. This commit added other features like a `idv_sp_required` for configuring this behavior to be enabled or disabled. This commit required an SP to be present but did not require the SP to actually request verification. This commit changes the code so that `IalContext` is invoked to check if verification was in fact requested. This way users can't go to an SP that does not require verification and start the verification process by navigating to `/verify`. changelog: User-Facing Improvements, SP IdV Requirement, Users can only undergo proofing if the SP IAL context is for identity verification or greater.
jmhooper
added a commit
that referenced
this pull request
Nov 27, 2023
…on (#9663) In #4634 we restricted the identity verification process to require a service provider for a user to undergo proofing. This commit added other features like a `idv_sp_required` for configuring this behavior to be enabled or disabled. This commit required an SP to be present but did not require the SP to actually request verification. This commit changes the code so that `IalContext` is invoked to check if verification was in fact requested. This way users can't go to an SP that does not require verification and start the verification process by navigating to `/verify`. changelog: User-Facing Improvements, SP IdV Requirement, Users can only undergo proofing if the SP IAL context is for identity verification or greater.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR on this subject!
If a user signs in directly to secure.login.gov, then attempts to go to the /verify path, they will be redirected back to the account page. This only applies to the production environments. Being redirected to the verify path via request from an SP is not affected.
@aduth noted in #4538 that this should probably apply to all /verify/* paths, not just /verify. This made us realize that users who have reset their account and need to re-proof will not have a SP context, but should also be allowed to continue.
The spec on the IdvController tests that the before action does what it is supposed to do, and the other specs simply assure that the before action is present on the controller.