Don't allow identity proofing in prod without SP context (LG-3942)#4538
Merged
Don't allow identity proofing in prod without SP context (LG-3942)#4538
Conversation
solipet
requested review from
aduth,
mitchellhenke,
stevegsa and
zachmargolis
aduth
reviewed
Dec 29, 2020
| before_action :confirm_two_factor_authenticated | ||
| before_action :confirm_idv_needed, only: [:fail] | ||
| before_action :profile_needs_reactivation?, only: [:index] | ||
| before_action :sp_context_needed?, only: [:index] |
Contributor
There was a problem hiding this comment.
Since this only applies to :index, and only the root IdvController, what would happen if I navigate to /verify/doc_auth or /verify/doc_auth/welcome ? Or are we primarily concerned with the base /verify path?
Contributor
Author
There was a problem hiding this comment.
Opened #4543 to block all {{/verify/*}} paths (which proved to be a bad idea...)
This was referenced Dec 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user signs in directly to secure.login.gov, then attempts to go to the
/verifypath, they will be redirected back to the account page. This only applies to the production environments. Being redirected to the verify path via request from an SP is not affected.