Skip to content

Log phone type even if we're not blocking VOIP numbers #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Jan 25, 2021
Merged

Log phone type even if we're not blocking VOIP numbers #4610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/forms/new_phone_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,12 @@ def extra_analytics_attributes
end

def validate_not_voip
return if phone.blank? || !FeatureManagement.voip_block?
return if phone.blank?

@phone_info = Telephony.phone_info(phone)

return unless FeatureManagement.voip_block?

if @phone_info.type == :voip &&
!FeatureManagement.voip_allowed_phones.include?(parsed_phone.e164)
errors.add(:phone, I18n.t('errors.messages.voip_check_error'))
Expand Down
5 changes: 3 additions & 2 deletions spec/forms/new_phone_form_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,11 @@
expect(FeatureManagement).to receive(:voip_block?).and_return(false)
end

it 'allows voip numbers, does not even make a voip check' do
expect(Telephony).to_not receive(:phone_info)
it 'does a voip check but does not enforce it' do
expect(Telephony).to receive(:phone_info).and_call_original

expect(result.success?).to eq(true)
expect(result.to_h).to include(phone_type: :voip)
end
end
end
Expand Down