Log phone type even if we're not blocking VOIP numbers#4610
Merged
zachmargolis merged 1 commit intomasterfrom Jan 25, 2021
Merged
Log phone type even if we're not blocking VOIP numbers#4610zachmargolis merged 1 commit intomasterfrom
zachmargolis merged 1 commit intomasterfrom
Conversation
jmhooper
approved these changes
Jan 25, 2021
mitchellhenke
approved these changes
Jan 25, 2021
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
Does the logging happen during the pinpoint call?
aduth
approved these changes
Jan 25, 2021
Contributor
Author
Probably clearer to see in the previous PR, but the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous we'd skip the check if the feature flag was off, now we run the check always