Skip to content

Fix error on bad password during password verification #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Jan 4, 2021
Merged

Fix error on bad password during password verification #4551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3efa097
add failing spec
Jan 4, 2021
69c434c
ensure decrypted_pii is set when rendering verify password
Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions app/controllers/users/verify_password_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,17 @@ class VerifyPasswordController < ApplicationController
before_action :confirm_personal_key

def new
@verify_password_form = VerifyPasswordForm.new(
user: current_user,
password: '',
decrypted_pii: decrypted_pii,
)
@decrypted_pii = decrypted_pii
end

def update
@decrypted_pii = decrypted_pii
result = verify_password_form.submit

if result.success?
handle_success(result)
else
flash[:error] = t('errors.messages.password_incorrect')
render :new
end
end
Expand Down
3 changes: 1 addition & 2 deletions app/views/users/verify_password/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

<div class='mt4'>
<%= accordion('review-verified-info', t('idv.messages.review.intro')) do %>
<% decrypted_pii = @verify_password_form.decrypted_pii %>
<%= render 'shared/pii_review', pii: decrypted_pii, phone: decrypted_pii[:phone] %>
<%= render 'shared/pii_review', pii: @decrypted_pii, phone: @decrypted_pii[:phone] %>
<% end %>
</div>
4 changes: 4 additions & 0 deletions spec/controllers/users/verify_password_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@

describe '#update' do
let(:form) { instance_double(VerifyPasswordForm) }
let(:pii) { { dob: Time.zone.today } }

before do
expect(controller).to receive(:verify_password_form).and_return(form)
Expand All @@ -79,8 +80,11 @@
end

context 'without valid password' do
render_views

it 'renders the new template' do
allow(form).to receive(:submit).and_return(response_bad)
allow(controller).to receive(:decrypted_pii).and_return(pii)

put :update, params: { user: { password: user.password } }

Expand Down