Fix error on bad password during password verification#4551
Merged
mitchellhenke merged 2 commits intomasterfrom Jan 4, 2021
Merged
Fix error on bad password during password verification#4551mitchellhenke merged 2 commits intomasterfrom
mitchellhenke merged 2 commits intomasterfrom
Conversation
zachmargolis
approved these changes
Jan 4, 2021
Contributor
Author
There was a problem hiding this comment.
oops unrelated, removing
mitchellhenke
force-pushed
the
mitchellhenke/fix-verify-password-error
branch
from
1dc3153 to
69c434c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@verify_password_formis expected to be defined to render:new, but the instance variable is never set in theupdatecall.This results in an error if the form validation fails: New Relic error
The template uses
@verify_password_formstrictly for the pii, so I moved the variable assignment up and out of the template and explicitly pass in@decrypted_piinow.The test also unexpectedly passes because controller specs do not render the view, and enabling view rendering causes the spec to fail.