Skip to content

Implement React-based document capture selfie liveness step#4009

Merged
aduth merged 10 commits intomasterfrom
aduth-selfie-step
Aug 7, 2020
Merged

Implement React-based document capture selfie liveness step#4009
aduth merged 10 commits intomasterfrom
aduth-selfie-step

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented Aug 4, 2020

Previously: #3999

Why: As part of the React-based document capture, the user will be prompted to take a photo of themselves for liveness verification.

The primary purpose of this pull request is to begin flesh out a common input component which can be used across ID documents capture and selfie capture for uploading an image or direct capture via the Acuant SDK.

It implements:

  • The text and photo input of the Selfie step
  • Device capture detection:
    • Displaying a "Take photo" button if the browser supports capture
    • Redirecting a click on the photo input to use Acuant capture if supported. Otherwise falling back to retaining previous behavior to show a file input.
  • Updating file input to support both file values (from file input) and data URLs (from Acuant)

It does not implement:

  • Triggering Acuant to capture in selfie mode
  • Error handling when the Acuant SDK responds to capture with a failure (as is the case when using Chrome to simulate)
  • Per implemented note about supporting both file value and data URL string value, after discussion with @ironman5366 and @jmhooper , this will be simplified in the future to just support string values
  • Additional upload options for mobile devices to choose to upload a file even if capture is also possible

Screenshots:

Mobile Desktop
mobile selfie desktop selfie

@aduth
Copy link
Copy Markdown
Contributor Author

aduth commented Aug 5, 2020

Note: The pull request at #4012 complements this in that the changes there may simplify what is required here after a rebase. As such, it may be easier to review #4009 before this one, as there are fewer changes.

This has been rebased after the merge of #4012, reducing overall changes slightly (from +326/-81 to +291/-77).

Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aduth added 9 commits August 7, 2020 16:12
**Why**: Since the test operates using FormSteps which manipulates history, it needs to restore to the original state

For future consideration: Maybe this should be a global test helper?
**Why** The design has submit occur on the selfie step
**Why**: Consistency with other test specs
**Why**: To be used in determining whether device has direct capture capability
**Why**: Document capture requires a selfie liveness check
**Why** Test case asserts false
@aduth aduth force-pushed the aduth-selfie-step branch from bf5c2db to ad50636 Compare August 7, 2020 20:14
@aduth aduth merged commit 85beebd into master Aug 7, 2020
@aduth aduth deleted the aduth-selfie-step branch August 7, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants