Conversation
1747971 to
6bdf517
Compare
32b0631 to
79a3949
Compare
1 task
79a3949 to
70819d6
Compare
Contributor
Author
|
Summarizing the discussion at #3938 (comment) :
† For example, should it behave like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: LG-3094, LG-3023
Currently configured to merge to (blocked by) #3931 in order to leverage assets behavior
Why: As a user trying to proof, I want the capture mode to be more intuitive in landscape and portrait orientation, so that I can easily capture images of my IDs and selfie.
The changes in this pull request introduce a new React component
<FullScreen />, implementing the behavior of a dismissible full-screen modal dialog. This is currently integrated in the work-in-progress single-page document authorization upload flow, shown in response to clicking the "Take photo" button in the verification step.Screenshot:
Notes:
focus-trapdependency has side effects in its imports which depend on DOM globals. These changes are included here, though could make sense to break off into a separate pull request. Overall it should simplify authoring tests in many cases.