Add React-based tips accordion to single-page document capture form#3931
Merged
Add React-based tips accordion to single-page document capture form#3931
Conversation
aduth
force-pushed
the
aduth-document-tips
branch
from
4da514c to
758e4b3
Compare
**Why**: Asset paths include a fingerprint which can't be known to the client unless provided by the server. Co-authored-by: Will Beddow <william.beddow@gsa.gov>
**Why**: Current Login.gov pages will check for and initialize any accordions present at page load. Since React components can be mounted after page load, and also need to initialize, there should be internal checks to protect against double initialization, since otherwise event handlers may be triggered multiple times.
**Why**: As an abstraction to simply render an image at the known asset path, encapsulating behavior to perform asset lookup by asset context
**Why**: To recreate the existing document capture flow, we will need to be able to represent collapsible accordion content in React
**Why**: Recreating the existing document capture flow requires integrating existing tips content
aduth
force-pushed
the
aduth-document-tips
branch
from
1747971 to
6bdf517
Compare
Contributor
Author
|
Depending on the design direction, we may not ultimately need the accordion component. That said, the assets initialization and context, as well as the bundled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: LG-3020, LG-3023
Integrates work from: #3911
Why: To recreate the existing document capture flow as a React component, it will be required to integrate existing tips content.
This pull request seeks to implement the necessary base components for the recreation of the document tips, including:
The implementation of the tips component is done in a way which anticipates that the steps for uploading the front and the back of a document would be largely the same.
It does not:
Screenshot:
To do: