Conversation
zachmargolis
approved these changes
Apr 24, 2020
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM but looks like there's a spec expectation we need to update:
1) multiple saml endpoints for a metadata request includes the correct auth and logout urls
Failure/Error:
expect(logout_node.attributes['Location']).to include(
['/api/saml/logout', endpoint_suffix].join(''),
)
NoMethodError:
undefined method `attributes' for nil:NilClass
# ./spec/features/saml/multiple_endpoints_spec.rb:93:in `block (3 levels) in <top (required)>'
# ./spec/rails_helper.rb:90:in `block (2 levels) in <top (required)>'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Remove single logout service from metadata in saml_idp
https://github.com/18F/saml_idp/pull/30/files