Skip to content

Remove single logout service from metadata #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achapm merged 4 commits into from
Apr 21, 2020
Merged

Remove single logout service from metadata #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5006919
removed single logout service from metadata
achapm Apr 21, 2020
e8a813e
Removed pry-byebug
achapm Apr 21, 2020
47b7657
improved test
achapm Apr 21, 2020
9bd2945
Fixed spec
achapm Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/saml_idp/metadata_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ def fresh
entity.IDPSSODescriptor protocolSupportEnumeration: protocol_enumeration do |descriptor|
build_key_descriptor descriptor
build_name_id_formats descriptor
descriptor.SingleLogoutService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST",
Location: single_logout_service_post_location
descriptor.SingleLogoutService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect",
Location: single_logout_service_post_location
descriptor.SingleSignOnService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST",
Location: single_service_post_location
descriptor.SingleSignOnService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect",
Expand Down
6 changes: 2 additions & 4 deletions spec/lib/saml_idp/metadata_builder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
module SamlIdp
describe MetadataBuilder do
include CloudhsmMockable

it "has a valid fresh" do
expect(subject.fresh).not_to be_empty
end
Expand Down Expand Up @@ -33,9 +33,7 @@ module SamlIdp

it "includes logout element" do
subject.configurator.single_logout_service_post_location = 'https://example.com/saml/logout'
expect(subject.fresh).to match(
'<SingleLogoutService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="https://example.com/saml/logout"/>'
)
expect(subject.fresh).not_to include('SingleLogoutService')
end
end
end
1 change: 0 additions & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
require 'rspec'
require 'capybara/rspec'
require 'capybara/rails'
require 'pry-byebug'

require 'ruby-saml'
require 'saml_idp'
Expand Down