Skip to content

Deploy RC 87.1 to staging#3077

Merged
stevegsa merged 12 commits intostages/stagingfrom
stages/rc-2019-07-08
Jul 8, 2019
Merged

Deploy RC 87.1 to staging#3077
stevegsa merged 12 commits intostages/stagingfrom
stages/rc-2019-07-08

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Jul 8, 2019

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • When fetching a single record from the database, #take is used instead
    of #first unless there is an #order call on the ActiveRecord relations.
    This prevents ActiveRecord from sorting by primary key which can result in slow
    queries.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

brodygov and others added 12 commits July 2, 2019 16:58
**How**: Set job_run_healthchecks_enabled = 'true' in Figaro.

**Why**: We want to check that the job run service is running and that
all jobs are executing successfully on their normal schedule.
* Move account reset notice into job_configurations.

As part of LG-1113, move the account reset email notification job out of
the recurring job controllers and into the built-in app job
configurations.

**Why**: We are moving away from triggering recurring jobs via lambdas
to instead run long-running background jobs using the
idp-jobs/job_configurations.rb framework, which allows each idp server
to pull jobs and run them as needed, without any external moving parts.

This makes adding a new recurring job entirely self-contained within the
identity-idp repo, so no interaction with AWS or lambdas or terraform or
any other repos is needed.

**How**:
- Remove lib/lambdas/account_reset_lambda.rb.
- Add a new job configuration for the account reset email job to
  `config/initializers/job_configurations.rb`, running every 5 minutes.
- Change the deprecated account reset controller to return HTTP 410, to
  indicate that the endpoint should not be used.
- Add tests of all the job_configurations.rb and fix tests for the
  changes.

* Add timestamps to the default rails log.

**Why**: We currently output logs to a file. We have no idea when these
events happen unless we add a timestamp.

**How**: Create a custom log formatter class that overrides the default
activesupport formatter. Check if the input appears to be JSON based on
leading/trailing `{}`, and output without any timestamp if so. That
preserves log parsing compatibility with the existing analytics ETL
pipelines.

* Add a few log formatter tests.
added disavowal link to "phone added" alert email

**Why**: so users can take clear action to change their password if
they receive notification that a phone not belonging to them has been
added to their account
**Why**: The current timeout is 1 minute, which is far too short when
you need to run a migration against a large database.

**How**: Change MIGRATION_STATEMENT_TIMEOUT from 60000 to 600000.

https://github.com/18F/identity-devops/issues/1514
Adds BETA SAM service provider config
@stevegsa stevegsa requested review from amoose and jmhooper July 8, 2019 19:22
@stevegsa stevegsa merged commit 270f305 into stages/staging Jul 8, 2019
@mitchellhenke mitchellhenke deleted the stages/rc-2019-07-08 branch December 28, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants