LG-1424 Allow user to disavow new phone event#3061
Merged
Conversation
**Why**: so users can take clear action to change their password if they receive notification that a phone not belonging to them has been added to their account
jmhooper
reviewed
Jul 3, 2019
Contributor
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
The code looks 💯 and it seems to work. I had one comment on the email text that we can ask Michelle about.
config/locales/user_mailer/en.yml
Outdated
| help: If you did not make this change, sign in to your profile and manage your | ||
| phone numbers. We recommend that you also change your password. | ||
| disavowal_link: here | ||
| help: If you did not make this change, you can reset your password %{disavowal_link}. |
Contributor
There was a problem hiding this comment.
We may still want to have something here about signing into your profile and managing your numbers.
Contributor
Author
There was a problem hiding this comment.
Changed the content to If you did not make this change, sign in to your profile and manage your phone numbers. We also recommend that you *reset your password*. !
(Asterisks signify the link)
jmhooper
approved these changes
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: so users can take clear action to change their password if they receive notification that a phone not belonging to them has been added to their account