Merged
Conversation
Deploy RC-72 to int
…racters (#2686) **Why**: It is confusing for the user to see the password strength meter green but the button is still disabled because the password is less than 12 characters. **How**: Update pw-strength.js to downgrade the strength value to 2 (so so) if the password length is less than 12.
Why: We need to track whether a user has an undeliverable address when they attempt to verify by mail. How: Download the USPS undeliverable address otp/codes from their sftp site daily. Add a bounced_at field to usps_confirmation_codes and add an index on otp fingerprint. For each code find the entry by otp fingerprint, set the bounced_at timestamp, and send an email notification to the user. Use locking to prevent a user from being notified twice.
**Why**: To provide reasonable limits on data we collect **How**: Limit profile fields to 255. Put a maximum on the field validation in the form validator.
**Why**: We want to roll out piv/cac as we find agencies that we believe we can support. **How**: We add the email domains for supported agencies to the list we test against.
**Why**: - Setting up the project with `bin/setup --docker` fails because setup commands should not be run as root. **How**: - While building the Docker image for the Rails application, create a new user and switch users to it from root. The remaining commands, including those run by `docker-compose run`, run as this new user instead of root. Fixes #2690.
jgsmith-usds
approved these changes
Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.