Merged
Conversation
**Why**: Fasterer is one of our linters to make sure we are writing efficient code. **How**: Rather than make a method that returns the value of an instance attribute, we use an attribute reader.
Deploy RC 65 to int
**Why**: We want to start with the right set of vendors for proofing. **How**: We initialize `@vendor` to `nil` rather than a truthy value.
Fix Idv::Proofer vendor initialization
Int: Fix Idv::Proofer vendor initialization
**Why**: Sometimes, we have an anonymous user. They don't have any configured phones. **How**: Add a method that returns `nil`
**Why**: Sometimes our gem bundle isn't in sync when we fetch the most recent `master` of `identity-devops`. This fixes that. **How**: Run `bundle install` after fetching the most recent `master` of `identity-devops`
Run `bundle install` in devops repo when releasing
…ymous-user Add nil phone_configuration to anonymous user
**Why**: We want a table to hold configurations for webauthn as a second factor for users. **How**: Create a new table with a one to many from users. Store the public_key with each configuration and create a unique index on user_id + public_key
…ions-table LG-597 Create WebAuthn Configurations Table
**Why**: The migration fails because the `references` keyword creates an index, so we don't need to call the index creation independently. Doing so causes the migration to fail. **How**: Remove the offending line.
…-in-webauthn-configurations Remove dup webauthn_configurations index creation
**Why**: To make it more consistent with other controllers and ensure all desired analytics are properly captured. **How**: - Use service objects to validate the granted token, capture analytics, and process the account deletion - Fix the link to create a new account to point to the email sign up page instead of the home page - Remove unnecessary token param from `delete_account/show` view - Move localizations out of Devise and into the `errors` file - Update controller specs to test all analytics and before_action - Update feature spec to test that the deletion confirmation email is sent
…erer Make user_access_key_overrides fasterer
**Why**: To prevent a 500 error when a user visits the `/account_reset/confirm_request` path while signed out
Take into account nil user in SmsLoginOptionPolicy
…00-error Fix failure screens throwing 500 error with failure_to_proof_url
Deploy RC 65 patch 2 to Int
**Why**: A user can go from no phone to a phone, and this fixes an infrequent exception around that. **How**: Move the formatting to the phone configuration model for this case and only call it if we have a phone configuration.
…-phone-configuration Catch no method error in formatted phone
**Why**: So the exception notifier doesn't raise an error and to allow the full log to be generated.
**Why**: I originally created this PR to address a performance issue flagged by the `fasterer` gem, which said to use `attr_reader` instead of an ivar for `personal_key`, but then I noticed that we're not even using that method except for in some specs, so I removed it and updated the specs to use `encrypted_recovery_code_digest` instead.
Refactor AccountReset::DeleteAccountController
Allow full exception logs for users without phone
Remove unused personal_key method
**Why**: To make it easier and faster to test with users who use an authentication app only. **How**: - Update dev:rake task to create a TOTP user - Prefill the TOTP code for that user
**Why**: We are no longer reading form these columns in favor of encrypted_recovery_code_digest
**Why**: The otp verification controller serves multiple puprose, phone confirmation during sign up, sign in, edit phone, and idv. As a result the logic is very complex and error prone. This commit creates a separate controller specific for the IdV phone OTP confirmation since it differs a good bit from the other use cases for phone confirmation.
LG-643 Add timeout to Twilio API calls
* [LG-574] make phone_configuration plural **Why**: We want to support multiple phone numbers. This is an intermediate step in that direction. **How**: We go through and look for all the places we call phone_configuration. We pluralize and try to see if we're asking a question about the collection or a particular one.
**Why**: So we can support strong authentication via hardware security keys as a new 2FA option **How**: Update the accounts page to list a user's webauthn configurations. Add new styling.
Update gems with bummr
See upgrade guide for more info: https://github.com/troessner/reek/blob/master/docs/Reek-4-to-Reek-5-migration.md
Revert changes to `find_with_email `
Update Reek from 4.8.1 to 5.0.2
**Why**: During LOA1 account creation, the user is given their personal key after setting up 2FA. However, once an LOA3 user passes the verification steps, and after they are prompted for their password in order to encrypt their data, they must receive a new personal key. In order to provide a better account creation experience for LOA3 users, we only show them the personal key once, instead of once after 2FA setup, and then again after verification. This was working as expected for users who used a phone for 2FA, but the logic for authentication app users was wrong.
…ns-for-a-user LG-598 LG-600 List/delete webauthn configurations for a user
Revert removal of #2351 (redirect uri validation)
LG-610 Don't show recovery code before IdV flow
**Why**: Figaro prefers strings for the config values and will convert the booleans into strings. This reduces confusion.
gregory-casamento
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md
Controllers
authenticated, make sure to add
before_action :confirm_two_factor_authenticatedas the first callback.
Database
Unsafe migrations are implemented over several PRs and over several
deploys to avoid production errors. The strong_migrations gem
will warn you about unsafe migrations and has great step-by-step instructions
for various scenarios.
Indexes were added if necessary. This article provides a good overview
of indexes in Rails.
Verified that the changes don't affect other apps (such as the dashboard)
When relevant, a rake task is created to populate the necessary DB columns
in the various environments right before deploying, taking into account the users
who might not have interacted with this column yet (such as users who have not
set a password yet)
Migrations against existing tables have been tested against a copy of the
production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
issues. In that case, all the migration did was add a new column and an index to
the Users table, which might seem innocuous.
Encryption
Routes
state or result in destructive behavior).
Session
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
Testing
and invalid inputs.