Skip to content

LG-598 LG-600 List/delete webauthn configurations for a user#2494

Merged
stevegsa merged 11 commits intomasterfrom
stevegsa-list-webauthn-configurations-for-a-user
Sep 10, 2018
Merged

LG-598 LG-600 List/delete webauthn configurations for a user#2494
stevegsa merged 11 commits intomasterfrom
stevegsa-list-webauthn-configurations-for-a-user

Conversation

@stevegsa
Copy link
Copy Markdown
Contributor

@stevegsa stevegsa commented Sep 7, 2018

Why: So we can support strong authentication via hardware security keys as a new 2FA option

How: Update the accounts page to list a user's webauthn configurations. Add new styling.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

@stevegsa stevegsa force-pushed the stevegsa-list-webauthn-configurations-for-a-user branch from 3ade475 to b30cb6e Compare September 7, 2018 03:44
@stevegsa
Copy link
Copy Markdown
Contributor Author

stevegsa commented Sep 7, 2018

Screenshots:

screen shot 2018-09-07 at 5 21 30 pm

screen shot 2018-09-07 at 5 22 38 pm

screen shot 2018-09-07 at 1 34 02 am

@stevegsa stevegsa changed the title LG-598 List webauthn configurations for a user LG-598 LG-600 List/delete webauthn configurations for a user Sep 7, 2018
@stevegsa stevegsa force-pushed the stevegsa-list-webauthn-configurations-for-a-user branch from 924883d to 0e0a1a8 Compare September 7, 2018 05:56
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be checked to make sure they aren't deleting their last mfa configuration. Essentially, if the user has multiple mfa options configured (other than personal key), then any one configuration can be removed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a server-side check to make sure the user isn't removing their last mfa option for their account.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the screenshot I have, this was "Remove". Might check with @rtwell-usds.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to stick with "Remove" please!

@stevegsa stevegsa force-pushed the stevegsa-list-webauthn-configurations-for-a-user branch from bb5f340 to ce897a7 Compare September 7, 2018 17:23
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: or webauthn_configurations.any?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a comma after "Sorry"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks repeated. Drop one of them?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that putting this here causes a double line when there's no configuration in the phone list. I moved it to be a .border-top.border-blue-light on the classes in line 10 (the top of the configuration)

**Why**: So we can support strong authentication via hardware security keys as a new 2FA option

**How**: Update the accounts page to list a user's webauthn configurations. Add new styling.
@stevegsa stevegsa force-pushed the stevegsa-list-webauthn-configurations-for-a-user branch from 398cae3 to 7cc367e Compare September 7, 2018 21:10
@stevegsa stevegsa merged commit abf9989 into master Sep 10, 2018
@amathews-fs amathews-fs deleted the stevegsa-list-webauthn-configurations-for-a-user branch January 7, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants