LG-598 LG-600 List/delete webauthn configurations for a user#2494
LG-598 LG-600 List/delete webauthn configurations for a user#2494
Conversation
3ade475 to
b30cb6e
Compare
924883d to
0e0a1a8
Compare
There was a problem hiding this comment.
This needs to be checked to make sure they aren't deleting their last mfa configuration. Essentially, if the user has multiple mfa options configured (other than personal key), then any one configuration can be removed.
There was a problem hiding this comment.
Need a server-side check to make sure the user isn't removing their last mfa option for their account.
config/locales/account/en.yml
Outdated
There was a problem hiding this comment.
In the screenshot I have, this was "Remove". Might check with @rtwell-usds.
There was a problem hiding this comment.
I'd like to stick with "Remove" please!
bb5f340 to
ce897a7
Compare
app/models/user.rb
Outdated
There was a problem hiding this comment.
Style: or webauthn_configurations.any?
config/locales/errors/en.yml
Outdated
There was a problem hiding this comment.
Need a comma after "Sorry"?
There was a problem hiding this comment.
This looks repeated. Drop one of them?
There was a problem hiding this comment.
I found that putting this here causes a double line when there's no configuration in the phone list. I moved it to be a .border-top.border-blue-light on the classes in line 10 (the top of the configuration)
**Why**: So we can support strong authentication via hardware security keys as a new 2FA option **How**: Update the accounts page to list a user's webauthn configurations. Add new styling.
398cae3 to
7cc367e
Compare



Why: So we can support strong authentication via hardware security keys as a new 2FA option
How: Update the accounts page to list a user's webauthn configurations. Add new styling.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md
Controllers
authenticated, make sure to add
before_action :confirm_two_factor_authenticatedas the first callback.
Database
Unsafe migrations are implemented over several PRs and over several
deploys to avoid production errors. The strong_migrations gem
will warn you about unsafe migrations and has great step-by-step instructions
for various scenarios.
Indexes were added if necessary. This article provides a good overview
of indexes in Rails.
Verified that the changes don't affect other apps (such as the dashboard)
When relevant, a rake task is created to populate the necessary DB columns
in the various environments right before deploying, taking into account the users
who might not have interacted with this column yet (such as users who have not
set a password yet)
Migrations against existing tables have been tested against a copy of the
production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
issues. In that case, all the migration did was add a new column and an index to
the Users table, which might seem innocuous.
Encryption
Routes
state or result in destructive behavior).
Session
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
Testing
and invalid inputs.