Revert "Stop reading personal key columns (#2313)"#2336
Merged
Conversation
This reverts commit 050a998.
jmhooper
requested review from
davemcorwin,
jgsmith-usds,
monfresh,
mryenq and
stevegsa
jgsmith-usds
approved these changes
Jul 18, 2018
jmhooper
added a commit
that referenced
this pull request
Jul 18, 2018
jmhooper
added a commit
that referenced
this pull request
Jul 19, 2018
* Revert "Revert "Stop reading personal key columns (#2313)" (#2336)" This reverts commit 109485d. * Use encrypted digest to check personal key config **Why**: Personal key has been changed to behave like password, where it is nil until a key is assigned to the user during a request. This commit checks the digest instead of the personal key method to determine if a user can sign in with a personal key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 050a998.
I didn't rebase this before merging and broke the 2fa options menu. This commit reverts so that master is green again while I fix it.