Stop reading old recovery code columns#2313
Merged
Conversation
**Why**: We're phasing out the old personal key columns in favor of using `encrypted_recovery_code_digest`. The old code was actually using the `#personal_key` method in a lot of places to determine if a user had a personal key, so this code switches that up. It also refactors the personal key to behave a bit more like a password. That could lay the groundwork for some more refactoring, but I didn't want to pursue it too far until @jgsmith-usds gets the 2FA refactor done.
jgsmith-usds
approved these changes
Jul 13, 2018
Contributor
jgsmith-usds
left a comment
There was a problem hiding this comment.
Generally looks good to me.
| end | ||
|
|
||
| def personal_key | ||
| @personal_key |
Contributor
There was a problem hiding this comment.
Minor style: or attr_reader :personal_key
Contributor
Author
|
This one missed the release, but that is okay because I want to do some more testing with it before it starts rolling out. |
jmhooper
added a commit
that referenced
this pull request
Jul 18, 2018
jmhooper
added a commit
that referenced
this pull request
Jul 18, 2018
jmhooper
added a commit
that referenced
this pull request
Jul 19, 2018
* Revert "Revert "Stop reading personal key columns (#2313)" (#2336)" This reverts commit 109485d. * Use encrypted digest to check personal key config **Why**: Personal key has been changed to behave like password, where it is nil until a key is assigned to the user during a request. This commit checks the digest instead of the personal key method to determine if a user can sign in with a personal key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: We're phasing out the old personal key columns in favor of
using
encrypted_recovery_code_digest.The old code was actually using the
#personal_keymethod in a lot ofplaces to determine if a user had a personal key, so this code switches
that up. It also refactors the personal key to behave a bit more like a
password. That could lay the groundwork for some more refactoring, but I
didn't want to pursue it too far until @jgsmith-usds gets the 2FA
refactor done.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
affect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
For secrets changes, make sure to update the S3 secrets bucket with the
new configs in all environments.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
When adding a new controller that requires the user to be fully
authenticated, make sure to add
before_action :confirm_two_factor_authenticated.