Skip to content

LG-315 Can't submit personal key after typo #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevegsa merged 1 commit into from
Jun 6, 2018
Merged

LG-315 Can't submit personal key after typo #2215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/app/form-validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ document.addEventListener('DOMContentLoaded', () => {
if (elements.length !== 0) {
[].forEach.call(elements, function(input) {
input.addEventListener('input', function () {
if (buttons.length !== 0 && input.valid) {
Copy link
Copy Markdown
Contributor

@jmhooper jmhooper Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the bug here is that input.valid returns undefined. I think we're meaning to say input.checkValidity().

Copy link
Copy Markdown
Contributor Author

@stevegsa stevegsa Jun 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was supposed to be validity.valid . Nice catch Hoops! I just assumed the form validation wasn't working and didn't look further.

if (buttons.length !== 0 && input.checkValidity()) {
[].forEach.call(buttons, function(button) {
if (button.disabled) {
button.disabled = false;
Expand Down