LG-315 Can't submit personal key after typo

[stevegsa]

Why: When a user attempts to confirm a personal key and mistypes the key, they receive an error and the continue button is disabled.

How: Fix the logic for enabling/disabling the button and checking form validation upon user input. Rspec and Capybara are insufficient to test the javascript disabling/enabling of the submit button.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

• For DB changes, check for missing indexes, check to see if the changes
  affect other apps (such as the dashboard), make sure the DB columns in the
  various environments are properly populated, coordinate with devops, plan
  migrations in separate steps.

• For route changes, make sure GET requests don't change state or result in
  destructive behavior. GET requests should only result in information being
  read, not written.

• For encryption changes, make sure it is compatible with data that was
  encrypted with the old code.

• For secrets changes, make sure to update the S3 secrets bucket with the
  new configs in all environments.

• Do not disable Rubocop or Reek offenses unless you are absolutely sure
  they are false positives. If you're not sure how to fix the offense, please
  ask a teammate.

• When reading data, write tests for nil values, empty strings,
  and invalid formats.

• When calling redirect_to in a controller, use _url, not _path.

• When adding user data to the session, use the user_session helper
  instead of the session helper so the data does not persist beyond the user's
  session.

• When adding a new controller that requires the user to be fully
  authenticated, make sure to add before_action :confirm_two_factor_authenticated.

[jmhooper]

I think the bug here is that input.valid returns undefined. I think we're meaning to say input.checkValidity().

[stevegsa]

It was supposed to be validity.valid . Nice catch Hoops! I just assumed the form validation wasn't working and didn't look further.

[jmhooper]

Lookin good