LG-305 Updated screen per design #2205
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,25 @@ | ||
| - title @view_model.title | ||
|
|
||
| h1.h2.my0 = t('idv.titles.session.phone') | ||
|
|
||
| .mt2 | ||
| == t('idv.messages.phone.alert') | ||
|
|
||
| ul.py1.m0 | ||
| - t('idv.messages.phone.rules').each do |msg| | ||
| li = msg | ||
|
|
||
| = simple_form_for(@view_model.idv_form, url: idv_phone_path, | ||
| html: { autocomplete: 'off', method: :put, role: 'form', class: 'mt2' }) do |f| | ||
| = f.label :phone, label: t('idv.form.phone'), class: 'bold' | ||
| = f.input :phone, required: true, input_html: { class: 'us-phone' }, label: false, | ||
| wrapper_html: { class: 'mr2' } | ||
|
|
||
| - if FeatureManagement.enable_usps_verification? | ||
| = render 'verification_options' | ||
|
|
||
| = f.button :submit, t('forms.buttons.continue'), class: 'btn-wide mt6' | ||
|
|
||
| = render 'shared/cancel', link: idv_cancel_path | ||
|
|
||
| = render @view_model.modal_partial, view_model: @view_model | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,18 +33,17 @@ en: | |
| unsupported_jurisdiction: Sorry, we can't verify people from this state. | ||
| unsupported_jurisdiction_sp: Please visit %{sp_name} to access your account. | ||
| form: | ||
| activate_by_mail: get a code via mail instead › | ||
|
Contributor
There was a problem hiding this comment. I would consider inserting the > via CSS using :after rather than having it be part of the text string. I think it will be better for a11y, and also be more flexible if the preferred style were to change.
Contributor
Author
There was a problem hiding this comment. not opposed to it in concept, however, there is at least one other place where the guillemet is present and I was just going with the flow. Originally, the one in English was different than Spanish and French, but per some the comment here, i changed them to be the same. |
||
| address1: Address | ||
| address2: Address (optional) | ||
| city: City | ||
| dob: Date of birth | ||
| dob_hint: 'example: 01/17/1964' | ||
| first_name: First name | ||
| last_name: Last name | ||
| no_alternate_phone_html: 'No phone? No problem: %{link}' | ||
| password: Password | ||
| phone: Phone Number | ||
| ssn_label_html: Social Security Number | ||
| state: State | ||
| state_id: ID number | ||
|
|
@@ -98,15 +97,13 @@ en: | |
| personal_key: This is your new personal key. Write it down and keep it in a | ||
| safe place. You will need it if you ever lose your password. | ||
| phone: | ||
| alert: This phone number <strong>must be</strong> | ||
| phone_of_record: Phone of record | ||
| rules: | ||
| - in your name, or a family member's name | ||
| - not a virtual phone (such as Google Voice or Skype) | ||
| - not a pre-paid phone number | ||
| - a U.S. number | ||
| return_to_profile: "‹ Return to your login.gov profile" | ||
| return_to_sp_html: You can now log into <strong>%{sp}</strong>. | ||
| review: | ||
|
|
@@ -189,7 +186,7 @@ en: | |
| review: Review and submit | ||
| select_verification: Choose how to confirm your address | ||
| session: | ||
| phone: Enter a phone number to help verify your identity | ||
| review: Enter your login.gov password | ||
| success: We've verified the information on your state-issued ID. | ||
| sessions: Information about you | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its hard to tell in github, but is this nesting the form within the ul?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope! but the diff view does make it look like it :)