Conversation
| - t('idv.messages.phone.rules').each do |msg| | ||
| li = msg | ||
|
|
||
| = simple_form_for(@view_model.idv_form, url: idv_phone_path, |
There was a problem hiding this comment.
Its hard to tell in github, but is this nesting the form within the ul?
There was a problem hiding this comment.
nope! but the diff view does make it look like it :)
| unsupported_jurisdiction_sp: Please visit %{sp_name} to access your account. | ||
| form: | ||
| activate_by_mail: get a code by letter. | ||
| activate_by_mail: get a code via mail instead › |
There was a problem hiding this comment.
I would consider inserting the > via CSS using :after rather than having it be part of the text string. I think it will be better for a11y, and also be more flexible if the preferred style were to change.
There was a problem hiding this comment.
not opposed to it in concept, however, there is at least one other place where the guillemet is present and I was just going with the flow.
Originally, the one in English was different than Spanish and French, but per some the comment here, i changed them to be the same.
3 participants
Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
affect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
For secrets changes, make sure to update the S3 secrets bucket with the
new configs in all environments.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
When adding a new controller that requires the user to be fully
authenticated, make sure to add
before_action :confirm_two_factor_authenticated.