Keep locale when cancelling SP-initiated signup#1662
Merged
zachmargolis merged 1 commit intomasterfrom Sep 8, 2017
Merged
Conversation
**Why**: For consistency
jmhooper
reviewed
Sep 8, 2017
|
|
||
| def cancel_link_path | ||
| sign_up_start_path(request_id: sp_session[:request_id]) | ||
| sign_up_start_path(request_id: sp_session[:request_id], locale: locale_url_param) |
Contributor
There was a problem hiding this comment.
Should we be doing this everywhere we're using path helpers, or is this a special case?
Contributor
Author
There was a problem hiding this comment.
We may want to do this everywhere we're using path helpers? This is overridden with a default in the controller context... (see ApplicationController#default_url_options) so that means everything not inside a template or a controller we could be missing
Contributor
There was a problem hiding this comment.
Cool, def something to look out moving forward
jmhooper
approved these changes
Sep 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: For consistency
Follow-up to #1634 (comment)
cc @tonychang-gov