Retain language preference when cancelling sign up#1634
Merged
Conversation
hursey013
force-pushed
the
bh-language-cancel
branch
from
8989d4a to
32747c5
Compare
app/decorators/session_decorator.rb
Outdated
Contributor
There was a problem hiding this comment.
We have the helper method locale_url_param included in a bunch of places (if not, include LocaleHelper here) It has the advantage of passing nil when we're in en to keep the URLs slightly cleaner?
Contributor
Author
There was a problem hiding this comment.
Good call, will update.
hursey013
force-pushed
the
bh-language-cancel
branch
from
27d5e01 to
b0fdbcb
Compare
hursey013
force-pushed
the
bh-language-cancel
branch
2 times, most recently
from
2cdbd33 to
185dfdf
Compare
|
I'm still seeing this in int. If I get redirected from the SP in French, then click the "Creer un compte", if I then click on the "Annuler" (Cancel) link, I am now in English. |
Contributor
|
Thanks @tonychang-gov, I was able to repro and will have a PR soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly pass along the locale when referencing
root_pathin cancel links. This will prevent the language preference from being lost.