-
Notifications
You must be signed in to change notification settings - Fork 166
Update gems with bummr #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update gems with bummr #1594
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
10a4478
Update bummr from 0.1.8 to 0.2.1
monfresh 1779656
Update dotiw from 3.1.1 to 4.0.0
monfresh d5bb4e1
Update faker from 1.7.3 to 1.8.4
monfresh 8a98b37
Update front_matter_parser from 0.1.0 to 0.1.1
monfresh f6ee7dd
Update hashie from 3.5.5 to 3.5.6
monfresh 76026ad
Update http_accept_language from 2.1.0 to 2.1.1
monfresh 93ee23f
Update httparty from 0.15.4 to 0.15.6
monfresh 0671294
Update i18n-tasks from 0.9.15 to 0.9.16
monfresh 339b4be
Update lograge from 0.5.1 to 0.6.0
monfresh f55ed27
Update newrelic_rpm from 4.2.0.334 to 4.3.0.335
monfresh f4f1ce4
Update overcommit from 0.39.1 to 0.40.0
monfresh 926a8fd
Update phonelib from 0.6.12 to 0.6.13
monfresh 73b3618
Update poltergeist from 1.15.0 to 1.16.0
monfresh 3abc3ca
Update premailer-rails from 1.9.6 to 1.9.7
monfresh f3caafb
Update rails from 4.2.8 to 4.2.9
monfresh f1a05d7
Update reek from 4.7.1 to 4.7.2
monfresh 7da7194
Update savon from 2.11.1 to 2.11.2
monfresh 1fece21
Update shoulda-matchers from 3.1.1 to 3.1.2
monfresh 123ec18
Update sidekiq from 5.0.3 to 5.0.4
monfresh 57f8535
Update timecop from 0.9.0 to 0.9.1
monfresh 1f2cbf8
Update zxcvbn-js from 4.4.2 to 4.4.3
monfresh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we bump the node package version to keep these in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. Good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's not available yet?
Should I revert the gem until the node package is available?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the Ruby gem's versioning does not necessarily correspond to the Dropbox versioning. It looks like he made a change to the Ruby code and updated the version number, so I think we're good to go here.
https://github.com/bitzesty/zxcvbn-js/commits/master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah as long as it's still compatible with our patch to swap out the underlying JS, it's probably fine
👍