Skip to content

LG-16720 Unmock A/B bucket routing in feature tests #12554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanechesnutt-ft merged 1 commit into from
Oct 7, 2025
Merged

LG-16720 Unmock A/B bucket routing in feature tests #12554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 58 additions & 54 deletions spec/features/idv/doc_auth/socure_document_capture_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,36 @@
let(:socure_docv_webhook_repeat_endpoints) { [] }
let(:timeout_socure_route) { idv_socure_document_capture_errors_url(error_code: :timeout) }

before(:each) do
allow(IdentityConfig.store).to receive(:socure_docv_enabled).and_return(true)
allow(DocAuthRouter).to receive(:doc_auth_vendor_for_bucket)
.and_return(Idp::Constants::Vendors::SOCURE)
before do
allow(IdentityConfig.store).to receive_messages(
Copy link
Copy Markdown
Contributor

@solipet solipet Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL - nice!

doc_auth_max_attempts: max_attempts,
doc_auth_passport_selfie_vendor_lexis_nexis_percent: 0,
doc_auth_passport_selfie_vendor_socure_percent: 100,
doc_auth_passport_selfie_vendor_switching_enabled: true,
doc_auth_passport_vendor_lexis_nexis_percent: 0,
doc_auth_passport_vendor_socure_percent: 100,
doc_auth_passport_vendor_switching_enabled: true,
doc_auth_selfie_vendor_lexis_nexis_percent: 0,
doc_auth_selfie_vendor_socure_percent: 100,
doc_auth_selfie_vendor_switching_enabled: true,
doc_auth_vendor_lexis_nexis_percent: 0,
doc_auth_vendor_socure_percent: 100,
doc_auth_vendor_switching_enabled: true,
ruby_workers_idv_enabled: false,
socure_docv_document_request_endpoint: fake_socure_docv_document_request_endpoint,
socure_docv_enabled: true,
socure_docv_webhook_repeat_endpoints:,
socure_docv_webhook_secret_key:,
)
allow_any_instance_of(ServiceProviderSession).to receive(:sp_name).and_return('Test SP')
allow(IdentityConfig.store).to receive(:socure_docv_webhook_secret_key)
.and_return(socure_docv_webhook_secret_key)
allow(IdentityConfig.store).to receive(:socure_docv_document_request_endpoint)
.and_return(fake_socure_docv_document_request_endpoint)
allow(IdentityConfig.store).to receive(:socure_docv_webhook_repeat_endpoints)
.and_return(socure_docv_webhook_repeat_endpoints)
socure_docv_webhook_repeat_endpoints.each { |endpoint| stub_request(:post, endpoint) }
allow(IdentityConfig.store).to receive(:ruby_workers_idv_enabled).and_return(false)
allow_any_instance_of(ApplicationController).to receive(:analytics).and_return(fake_analytics)
allow_any_instance_of(ApplicationController).to receive(:attempts_api_tracker).and_return(
attempts_api_tracker,
)
allow_any_instance_of(SocureDocvResultsJob).to receive(:analytics).and_return(fake_analytics)
@docv_transaction_token = stub_docv_document_request(user:)
allow(IdentityConfig.store).to receive(:doc_auth_max_attempts).and_return(max_attempts)
reload_ab_tests
end

context 'happy path', allow_browser_log: true do
Expand All @@ -58,13 +68,12 @@
context 'when the user times out waiting for results' do
before do
DocAuth::Mock::DocAuthMockClient.reset!
allow(IdentityConfig.store)
.to receive(:in_person_proofing_enabled).and_return(true)
allow(IdentityConfig.store)
.to receive(:in_person_doc_auth_button_enabled).and_return(true)
allow(IdentityConfig.store).to receive_messages(
doc_auth_socure_wait_polling_timeout_minutes: 0,
in_person_doc_auth_button_enabled: true,
in_person_proofing_enabled: true,
)
allow(Idv::InPersonConfig).to receive(:enabled_for_issuer?).and_return(true)
allow(IdentityConfig.store).to receive(:doc_auth_socure_wait_polling_timeout_minutes)
.and_return(0)
allow_any_instance_of(DocumentCaptureSession).to receive(:load_result).and_return(nil)
end

Expand Down Expand Up @@ -432,13 +441,12 @@

context 'when a passport is submitted' do
before do
allow(IdentityConfig.store).to receive(:doc_auth_passports_enabled).and_return(true)
allow(IdentityConfig.store).to receive(:doc_auth_passports_percent).and_return(100)
allow(IdentityConfig.store).to receive(:doc_auth_passport_vendor_default)
.and_return(Idp::Constants::Vendors::SOCURE)
allow(IdentityConfig.store).to receive_messages(
doc_auth_passports_enabled: true,
doc_auth_passports_percent: 100,
)
stub_request(:get, IdentityConfig.store.dos_passport_composite_healthcheck_endpoint)
.to_return_json({ status: 200, body: { status: 'UP' } })
reload_ab_tests
DocAuth::Mock::DocAuthMockClient.reset!
@docv_stub = stub_docv_verification_data_pass(
docv_transaction_token: @docv_transaction_token,
Expand Down Expand Up @@ -510,18 +518,16 @@
context 'when a selfie is required' do
let(:socure_docv_webhook_repeat_endpoints) { [] }
let(:max_attempts) { 4 }

before do
allow(IdentityConfig.store).to receive(:use_vot_in_sp_requests).and_return(true)
allow(IdentityConfig.store).to receive_messages(
doc_auth_socure_wait_polling_timeout_minutes: 0,
idv_socure_reason_codes_docv_selfie_fail: ['fail'],
idv_socure_reason_codes_docv_selfie_not_processed: ['not_processed'],
idv_socure_reason_codes_docv_selfie_pass: ['pass'],
use_vot_in_sp_requests: true,
)
visit_idp_from_oidc_sp_with_ial2(facial_match_required: true)
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_pass)
.and_return(['pass'])
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_fail)
.and_return(['fail'])
allow(IdentityConfig.store)
.to receive(:idv_socure_reason_codes_docv_selfie_not_processed)
.and_return(['not_processed'])
allow(IdentityConfig.store).to receive(:doc_auth_socure_wait_polling_timeout_minutes)
.and_return(0)
stub_request(:post, IdentityConfig.store.dos_passport_mrz_endpoint)
.to_return_json({ status: 200, body: { response: 'YES' } })
end
Expand Down Expand Up @@ -628,15 +634,13 @@
context 'selfie required' do
let(:max_attempts) { 5 }
before do
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_pass)
.and_return(['pass'])
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_fail)
.and_return(['fail'])
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_not_processed)
.and_return(['not_processed'])
allow(IdentityConfig.store).to receive(:doc_auth_socure_wait_polling_timeout_minutes)
.and_return(0)
allow(IdentityConfig.store).to receive(:use_vot_in_sp_requests).and_return(true)
allow(IdentityConfig.store).to receive_messages(
doc_auth_socure_wait_polling_timeout_minutes: 0,
idv_socure_reason_codes_docv_selfie_fail: ['fail'],
idv_socure_reason_codes_docv_selfie_not_processed: ['not_processed'],
idv_socure_reason_codes_docv_selfie_pass: ['pass'],
use_vot_in_sp_requests: true,
)
visit_idp_from_oidc_sp_with_ial2(facial_match_required: true)
sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_hybrid_handoff_step
Expand Down Expand Up @@ -837,21 +841,21 @@ def expect_rate_limited_header(expected_to_be_present)

before do
service_provider = create(:service_provider, :active, :in_person_proofing_enabled)
allow(IdentityConfig.store).to receive(:doc_auth_selfie_desktop_test_mode).and_return(false)
allow(IdentityConfig.store).to receive(:in_person_proofing_enabled).and_return(true)
allow(IdentityConfig.store).to receive(:in_person_proofing_opt_in_enabled).and_return(
in_person_proofing_opt_in_enabled,
allow(IdentityConfig.store).to receive_messages(
allowed_biometric_ial_providers: [service_provider.issuer],
allowed_valid_authn_contexts_semantic_providers: [service_provider.issuer],
doc_auth_selfie_desktop_test_mode: false,
doc_auth_vendor_lexis_nexis_percent: 0,
doc_auth_vendor_socure_percent: 100,
doc_auth_vendor_switching_enabled: true,
in_person_proofing_enabled: true,
in_person_proofing_opt_in_enabled: in_person_proofing_opt_in_enabled,
socure_docv_enabled: true,
)
allow(IdentityConfig.store).to receive(:allowed_biometric_ial_providers)
.and_return([service_provider.issuer])
allow(IdentityConfig.store).to receive(
:allowed_valid_authn_contexts_semantic_providers,
).and_return([service_provider.issuer])
allow_any_instance_of(ServiceProvider).to receive(:in_person_proofing_enabled)
.and_return(false)
allow(IdentityConfig.store).to receive(:socure_docv_enabled).and_return(true)
allow(DocAuthRouter).to receive(:doc_auth_vendor_for_bucket)
.and_return(Idp::Constants::Vendors::SOCURE)
reload_ab_tests

visit_idp_from_sp_with_ial2(
:oidc,
**{ client_id: service_provider.issuer,
Expand Down
10 changes: 7 additions & 3 deletions spec/features/idv/doc_auth/socure_internal_error_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,17 @@
before do
allow_any_instance_of(ApplicationController).to receive(:analytics).and_return(fake_analytics)

allow(IdentityConfig.store).to receive(:socure_docv_enabled).and_return(true)
allow(DocAuthRouter).to receive(:doc_auth_vendor_for_bucket)
.and_return(Idp::Constants::Vendors::SOCURE)
allow(IdentityConfig.store).to receive_messages(
socure_docv_enabled: true,
doc_auth_vendor_lexis_nexis_percent: 0,
doc_auth_vendor_socure_percent: 100,
doc_auth_vendor_switching_enabled: true,
)

stub_docv_document_request(
body: { status: socure_status, referenceId: reference_id, msg: socure_msg },
)
reload_ab_tests
end

context 'mobile flow', :js, driver: :headless_chrome_mobile do
Expand Down
14 changes: 12 additions & 2 deletions spec/features/idv/hybrid_mobile/entry_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,17 @@
complete_doc_auth_steps_before_hybrid_handoff_step
click_send_link

expect(page).to have_content(t('doc_auth.headings.text_message'))

link
end

let(:link_to_visit) { link_sent_via_sms }

before do
reload_ab_tests
end

context 'valid link' do
before do
allow(IdentityConfig.store).to receive(:socure_docv_enabled).and_return(true)
Expand All @@ -43,9 +49,13 @@

context 'when socure is the doc auth vendor' do
before do
allow(DocAuthRouter).to receive(:doc_auth_vendor_for_bucket)
.and_return(Idp::Constants::Vendors::SOCURE)
allow(IdentityConfig.store).to receive_messages(
doc_auth_vendor_lexis_nexis_percent: 0,
doc_auth_vendor_socure_percent: 100,
doc_auth_vendor_switching_enabled: true,
)
stub_docv_document_request
reload_ab_tests
end

it 'puts the user on the socure document capture page' do
Expand Down
86 changes: 44 additions & 42 deletions spec/features/idv/hybrid_mobile/hybrid_socure_mobile_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,35 @@
end

before do
allow(FeatureManagement).to receive(:doc_capture_polling_enabled?).and_return(true)
allow(IdentityConfig.store).to receive(:socure_docv_enabled).and_return(true)
allow(DocAuthRouter).to receive(:doc_auth_vendor_for_bucket)
.and_return(Idp::Constants::Vendors::SOCURE)
allow(IdentityConfig.store).to receive(:use_vot_in_sp_requests).and_return(true)
allow(IdentityConfig.store).to receive(:ruby_workers_idv_enabled).and_return(false)
allow(IdentityConfig.store).to receive(:socure_docv_document_request_endpoint)
.and_return(fake_socure_docv_document_request_endpoint)
allow(IdentityConfig.store).to receive(:socure_docv_webhook_repeat_endpoints)
.and_return(socure_docv_webhook_repeat_endpoints)
allow(IdentityConfig.store).to receive_messages(
doc_auth_passport_selfie_vendor_lexis_nexis_percent: 0,
doc_auth_passport_selfie_vendor_socure_percent: 100,
doc_auth_passport_selfie_vendor_switching_enabled: true,
doc_auth_passport_vendor_lexis_nexis_percent: 0,
doc_auth_passport_vendor_socure_percent: 100,
doc_auth_passport_vendor_switching_enabled: true,
doc_auth_selfie_vendor_lexis_nexis_percent: 0,
doc_auth_selfie_vendor_socure_percent: 100,
doc_auth_selfie_vendor_switching_enabled: true,
doc_auth_vendor_lexis_nexis_percent: 0,
doc_auth_vendor_socure_percent: 100,
doc_auth_vendor_switching_enabled: true,
ruby_workers_idv_enabled: false,
socure_docv_document_request_endpoint: fake_socure_docv_document_request_endpoint,
socure_docv_enabled: true,
socure_docv_webhook_repeat_endpoints:,
use_vot_in_sp_requests: true,
)
socure_docv_webhook_repeat_endpoints.each { |endpoint| stub_request(:post, endpoint) }
allow(FeatureManagement).to receive(:doc_capture_polling_enabled?).and_return(true)
allow(Telephony).to receive(:send_doc_auth_link).and_wrap_original do |impl, config|
@sms_link = config[:link]
impl.call(**config)
end.at_least(1).times
@docv_transaction_token = stub_docv_document_request(user:)
stub_analytics
allow_any_instance_of(SocureDocvResultsJob).to receive(:analytics).and_return(@analytics)
reload_ab_tests
end

context 'happy path', allow_browser_log: true do
Expand Down Expand Up @@ -150,12 +161,8 @@
context 'when a passport is submitted' do
before do
allow(IdentityConfig.store).to receive(:doc_auth_passports_enabled).and_return(true)
allow(IdentityConfig.store).to receive(:doc_auth_passports_percent).and_return(100)
allow(IdentityConfig.store).to receive(:doc_auth_passport_vendor_default)
.and_return(Idp::Constants::Vendors::SOCURE)
stub_request(:get, IdentityConfig.store.dos_passport_composite_healthcheck_endpoint)
.to_return_json({ status: 200, body: { status: 'UP' } })
reload_ab_tests
DocAuth::Mock::DocAuthMockClient.reset!
stub_docv_verification_data_pass(
docv_transaction_token: @docv_transaction_token,
Expand Down Expand Up @@ -240,16 +247,14 @@

context 'when a selfie is required', :js do
before do
allow(IdentityConfig.store).to receive(:doc_auth_max_attempts).and_return(4)
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_pass)
.and_return(['pass'])
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_fail)
.and_return(['fail'])
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_not_processed)
.and_return(['not_processed'])
allow(IdentityConfig.store).to receive(:doc_auth_socure_wait_polling_timeout_minutes)
.and_return(0)
allow(IdentityConfig.store).to receive(:use_vot_in_sp_requests).and_return(true)
allow(IdentityConfig.store).to receive_messages(
doc_auth_max_attempts: 4,
doc_auth_socure_wait_polling_timeout_minutes: 0,
idv_socure_reason_codes_docv_selfie_fail: ['fail'],
idv_socure_reason_codes_docv_selfie_not_processed: ['not_processed'],
idv_socure_reason_codes_docv_selfie_pass: ['pass'],
use_vot_in_sp_requests: true,
)
stub_request(:post, IdentityConfig.store.dos_passport_mrz_endpoint)
.to_return_json({ status: 200, body: { response: 'YES' } })
end
Expand Down Expand Up @@ -410,15 +415,13 @@
context 'user times out waiting for result' do
before do
DocAuth::Mock::DocAuthMockClient.reset!
allow(IdentityConfig.store)
.to receive(:in_person_proofing_enabled).and_return(true)
allow(IdentityConfig.store)
.to receive(:in_person_doc_auth_button_enabled).and_return(true)
allow(IdentityConfig.store)
.to receive(:doc_auth_passports_enabled).and_return(false)
allow(IdentityConfig.store).to receive_messages(
doc_auth_passports_enabled: false,
doc_auth_socure_wait_polling_timeout_minutes: 0,
in_person_doc_auth_button_enabled: true,
in_person_proofing_enabled: true,
)
allow(Idv::InPersonConfig).to receive(:enabled_for_issuer?).and_return(true)
allow(IdentityConfig.store).to receive(:doc_auth_socure_wait_polling_timeout_minutes)
.and_return(0)
allow_any_instance_of(DocumentCaptureSession).to receive(:load_result).and_return(nil)
end

Expand Down Expand Up @@ -729,17 +732,16 @@

context 'selfie is required' do
before do
allow(IdentityConfig.store).to receive(:doc_auth_max_attempts).and_return(6)
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_pass)
.and_return(['pass'])
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_fail)
.and_return(['fail'])
allow(IdentityConfig.store).to receive(:idv_socure_reason_codes_docv_selfie_not_processed)
.and_return(['not_processed'])
allow(IdentityConfig.store).to receive(:doc_auth_socure_wait_polling_timeout_minutes)
.and_return(0)
allow(IdentityConfig.store).to receive(:use_vot_in_sp_requests).and_return(true)
allow(IdentityConfig.store).to receive_messages(
doc_auth_max_attempts: 6,
doc_auth_socure_wait_polling_timeout_minutes: 0,
idv_socure_reason_codes_docv_selfie_fail: ['fail'],
idv_socure_reason_codes_docv_selfie_not_processed: ['not_processed'],
idv_socure_reason_codes_docv_selfie_pass: ['pass'],
use_vot_in_sp_requests: true,
)
end

it 'proofs and hands off to mobile', js: true do
expect(SocureDocvRepeatWebhookJob).not_to receive(:perform_later)

Expand Down