Skip to content

LG-16720 Unmock A/B bucket routing in feature tests#12554

Merged
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-16720
Oct 7, 2025
Merged

LG-16720 Unmock A/B bucket routing in feature tests#12554
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-16720

Conversation

@shanechesnutt-ft
Copy link
Copy Markdown
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-16720

🛠 Summary of changes

Removed mocks on DocAuthRouter for IdV feature specs

📜 Testing Plan

  • Automation tests pass

Copy link
Copy Markdown
Contributor

@AShukla-GSA AShukla-GSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed LGTM

Copy link
Copy Markdown
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

allow(DocAuthRouter).to receive(:doc_auth_vendor_for_bucket)
.and_return(Idp::Constants::Vendors::SOCURE)
before do
allow(IdentityConfig.store).to receive_messages(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL - nice!

changelog: Internal, Feature Tests, Unmock A/B bucket routing in feature tests
@shanechesnutt-ft shanechesnutt-ft merged commit cd2c6f8 into main Oct 7, 2025
1 check passed
@shanechesnutt-ft shanechesnutt-ft deleted the sc/LG-16720 branch October 7, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants