Skip to content

Check for duplicates only within requesting service provider#12391

Merged
vrajmohan merged 1 commit intomainfrom
vm-dup-ssn-within-service-provider
Aug 5, 2025
Merged

Check for duplicates only within requesting service provider#12391
vrajmohan merged 1 commit intomainfrom
vm-dup-ssn-within-service-provider

Conversation

@vrajmohan
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-16327

🛠 Summary of changes

  1. Find duplicates only within current service provider
  2. Refactor tests
  3. Refactor code to make intention clear and remove unnecessary calls

@vrajmohan vrajmohan requested a review from a team August 4, 2025 15:31
changelog: Upcoming Features, One Account, Check for duplicates only within requesting service provider

Fixes https://cm-jira.usa.gov/browse/LG-16327
@vrajmohan vrajmohan force-pushed the vm-dup-ssn-within-service-provider branch from a7e7cf2 to d1fce20 Compare August 5, 2025 21:27
@vrajmohan vrajmohan merged commit d950b9a into main Aug 5, 2025
1 check passed
@vrajmohan vrajmohan deleted the vm-dup-ssn-within-service-provider branch August 5, 2025 21:40
@JzmCrow
Copy link

JzmCrow commented Aug 7, 2025

@AntBar82 this has been merged.

mdiarra3 added a commit that referenced this pull request Aug 7, 2025
* Update translations for the LG33 error page (#12388)

changelog: Upcoming Features, One Account, Update translations for the LG33 error page

* Update json gem (#12386)

changelog: Internal, Maintenance, Update json gem

* Upgrade saml_idp to 0.23.9-18f (#12389)

changelog: Internal, Security, Update ruby-saml gem

* Undo unintended resolution proofing change (#12390)

* Undo unintended changes from One Account work

changelog: Bug Fixes, Resolution Proofing, Undo unintended changes from One Account work

These changes from commit f628580 were
not intended.

* Reinstate dependency so that cascaded deletes can happen

* Lg-16484 create new alert banner for dos api down (#12387)

* changelog: Internal, Doc Auth, adding logging for step in dos api health check

* Adding step as analytics argument

* Fixing specs

* Updated param comment and spec

* Adding back arguments in choose id type concern spec

* Adding specs for logging

* Resolving PR comments

* Fix LG-99 metric in Fraud Report | GL-Data-184 (#12396)

Fixes uppercase typo 
Changes query order for efficiency 

changelog: Internal, Reporting, Fix LG-99 metric in Fraud Report

Refer to: https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/184
Co-authored-by: shilen.patel <shilen.patel@gsa.gov>

* changelog: Internal, Doc Auth, adding spec to confirm mobile flow routes from how to verify to doc capture after ipp canceled (#12393)

* changelog: Internal, Reporting,fix IRS Credential Tenure Metric query… (#12394)

* changelog: Internal, Reporting,fix IRS Credential Tenure Metric query anb combine report with IRS Fraud Metric

* changelog: Internal, Reporting,fix spec file

* changelog: Internal, Reporting,fix lint issue

* Check for duplicates only within requesting service provider (#12391)

changelog: Upcoming Features, One Account, Check for duplicates only within requesting service provider

Fixes https://cm-jira.usa.gov/browse/LG-16327

---------

Co-authored-by: Vraj Mohan <vraj.mohan@gsa.gov>
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Co-authored-by: A Shukla <abir.shukla@gsa.gov>
Co-authored-by: Gerardo E. Cruz-Ortiz <59618057+astrogeco@users.noreply.github.com>
Co-authored-by: shilen.patel <shilen.patel@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants