Undo unintended resolution proofing change#12390
Merged
Conversation
changelog: Bug Fixes, Resolution Proofing, Undo unintended changes from One Account work These changes from commit f628580 were not intended.
mdiarra3
reviewed
Aug 4, 2025
| # rubocop:enable Rails/InverseOf | ||
| has_many :gpo_confirmation_codes, dependent: :destroy | ||
| has_one :in_person_enrollment, dependent: :destroy | ||
| has_many :duplicate_profile_confirmations, dependent: :destroy |
Contributor
There was a problem hiding this comment.
why dont we just run a schema to delete duplicate profile confirmations, we arent referencing it anywhere else and dont use that table anymore anyways.
Contributor
Author
mdiarra3
approved these changes
Aug 4, 2025
mdiarra3
added a commit
that referenced
this pull request
Aug 5, 2025
* Update translations for the LG33 error page (#12388) changelog: Upcoming Features, One Account, Update translations for the LG33 error page * Update json gem (#12386) changelog: Internal, Maintenance, Update json gem * Upgrade saml_idp to 0.23.9-18f (#12389) changelog: Internal, Security, Update ruby-saml gem * Undo unintended resolution proofing change (#12390) * Undo unintended changes from One Account work changelog: Bug Fixes, Resolution Proofing, Undo unintended changes from One Account work These changes from commit f628580 were not intended. * Reinstate dependency so that cascaded deletes can happen --------- Co-authored-by: Vraj Mohan <vraj.mohan@gsa.gov> Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
mdiarra3
added a commit
that referenced
this pull request
Aug 7, 2025
* Update translations for the LG33 error page (#12388) changelog: Upcoming Features, One Account, Update translations for the LG33 error page * Update json gem (#12386) changelog: Internal, Maintenance, Update json gem * Upgrade saml_idp to 0.23.9-18f (#12389) changelog: Internal, Security, Update ruby-saml gem * Undo unintended resolution proofing change (#12390) * Undo unintended changes from One Account work changelog: Bug Fixes, Resolution Proofing, Undo unintended changes from One Account work These changes from commit f628580 were not intended. * Reinstate dependency so that cascaded deletes can happen * Lg-16484 create new alert banner for dos api down (#12387) * changelog: Internal, Doc Auth, adding logging for step in dos api health check * Adding step as analytics argument * Fixing specs * Updated param comment and spec * Adding back arguments in choose id type concern spec * Adding specs for logging * Resolving PR comments * Fix LG-99 metric in Fraud Report | GL-Data-184 (#12396) Fixes uppercase typo Changes query order for efficiency changelog: Internal, Reporting, Fix LG-99 metric in Fraud Report Refer to: https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/184 Co-authored-by: shilen.patel <shilen.patel@gsa.gov> * changelog: Internal, Doc Auth, adding spec to confirm mobile flow routes from how to verify to doc capture after ipp canceled (#12393) * changelog: Internal, Reporting,fix IRS Credential Tenure Metric query… (#12394) * changelog: Internal, Reporting,fix IRS Credential Tenure Metric query anb combine report with IRS Fraud Metric * changelog: Internal, Reporting,fix spec file * changelog: Internal, Reporting,fix lint issue * Check for duplicates only within requesting service provider (#12391) changelog: Upcoming Features, One Account, Check for duplicates only within requesting service provider Fixes https://cm-jira.usa.gov/browse/LG-16327 --------- Co-authored-by: Vraj Mohan <vraj.mohan@gsa.gov> Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> Co-authored-by: A Shukla <abir.shukla@gsa.gov> Co-authored-by: Gerardo E. Cruz-Ortiz <59618057+astrogeco@users.noreply.github.com> Co-authored-by: shilen.patel <shilen.patel@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.