LG-16344-passport-validation-patch

app/forms/idv/api_image_upload_form.rb

@@ -535,11 +535,12 @@ def store_failed_images(client_response, doc_pii_response)
         }
       end
       # doc auth failed due to non network error or doc_pii is not valid
+      failed_front_fingerprint = nil
+      failed_back_fingerprint = nil
+      failed_passport_fingerprint = nil
+
       if client_response && !client_response.success? && !client_response.network_error?
         errors_hash = client_response.errors&.to_h || {}
-        failed_front_fingerprint = nil
-        failed_back_fingerprint = nil
-        failed_passport_fingerprint = nil
 
         if errors_hash[:front] || errors_hash[:back] || errors_hash[:passport]
           if errors_hash[:front]

spec/forms/idv/api_image_upload_form_spec.rb

@@ -1018,6 +1018,44 @@
           expect(response.errors[:passport]).to eq(message)
         end
       end
+
+      context 'Passport doc auth succeeds but PII validation fails' do
+        let(:passport_image) { DocAuthImageFixtures.passport_passed_yaml }
+        let(:successful_doc_auth_response) do
+          DocAuth::Mock::ResultResponse.new(
+            passport_image.read,
+            image_config,
+          )
+        end
+        let(:failed_pii_response) do
+          Idv::DocAuthFormResponse.new(
+            success: false,
+            errors: { doc_pii: 'bad' },
+            extra: {
+              pii_like_keypaths: pii_like_keypaths_passport,
+              attention_with_barcode: false,
+              id_issued_status: 'missing',
+              id_expiration_status: 'missing',
+              passport_issued_status: 'missing',
+              passport_expiration_status: 'missing',
+            },
+          )
+        end
+
+        before do
+          allow_any_instance_of(described_class)
+            .to receive(:post_images_to_client)
+            .and_return(successful_doc_auth_response)
+          allow_any_instance_of(Idv::DocPiiForm).to receive(:submit).and_return(failed_pii_response)
+        end
+
+        it 'does not raise NameError when passport fingerprint variable is accessed' do
+          expect { form.submit }.not_to raise_error
+
+          response = form.submit
+          expect(response.success?).to eq(false)
+        end
+      end
     end
 
     describe 'image source' do