Merged
Conversation
Contributor
|
LGTM as well! |
WilliamBirdsall
approved these changes
Jul 9, 2025
Mawar2
force-pushed
the
mwarren-lg-16344-passport-validation-patch
branch
from
812dc3f to
a409bbd
Compare
…t fails PII validation
Mawar2
force-pushed
the
mwarren-lg-16344-passport-validation-patch
branch
from
a409bbd to
e22c592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16344
🛠 Summary of changes
This PR fixes a crash when a passport document passes initial authentication but fails PII validation.
The issue was that
failed_passport_fingerprintwas declared inside a conditional block and accessed in a different scope, causing a NameError. I moved the variable declarations outside the conditional blocks to ensure they’re always available.I added a test case to verify this scenario works without errors. The fix follows the same pattern used elsewhere in the file for similar variable scoping.
📜 Testing Plan