LG-16298 bug fix for Create Job to Track Deletion Workflow Drop-offs

[kevinsmaster5]

🎫 Ticket

Link to the relevant ticket:
LG-16298

🛠 Summary of changes

Resolves the timing logic behind the job created with #12187
Adds more comprehensive testing.

📜 Testing Plan

• In local environment create 2 or more accounts.
• Sign in with the accounts and create a deletion request by selecting another method at the MFA phase then commencing with deletion
• Wait for the token to be awarded. You can hasten that by setting the local config account_reset_wait_period_days: 0 Keep the 2 browser tabs with the simulated email open
• Go into the rails console and pick one of the 2 AccountResetRequest objects and update the granted_at to 2.days.ago
• Wait for the job to run and check the console for that account to have been updated with a canceled_at date and request_token & granted_token to both be null.
• Attempt to use the Deletion button in the simulated email tabs.
• The account with the altered reset request should fail and flash the expired token message but the other one should work.

[vrajmohan]

Also, why is the changelog under OneAccount?

[vrajmohan]

Why a SQL query? Why not https://guides.rubyonrails.org/active_record_querying.html#and-conditions?

[kevinsmaster5]

I referred to prior art with this worker job https://github.com/18F/identity-idp/blob/main/app/jobs/grant_account_reset_requests_and_send_emails_job.rb#L31-L39 using SQL. I assumed it was more efficient to use a SQL query.

[vrajmohan]

The ticket calls for a separate field in the model called expired_at? Why are we using cancelled_at, which would denote a cancellation by user as opposed to the system?

[kevinsmaster5]

As discussed in Slack. Determined that the *_at database change is not needed to accomplish the intent of the story.

[vrajmohan]

Why is this required? Ditto for lines 20, 29 and 30.

[kevinsmaster5]

Removed those with ecc86e1

[vrajmohan]

This seems to be a very weak statement of the expected behavior. Wouldn't "it expires requests with expired grant tokens and ignores valid grant tokens" be better?

[kevinsmaster5]

You are correct, that's a much better statement. Thank you!
ecc86e1