LG-16204 Create Job to Track Deletion Workflow Drop-offs and Notify Users#12187
Merged
kevinsmaster5 merged 6 commits intomainfrom May 21, 2025
Merged
Conversation
Mawar2
approved these changes
May 20, 2025
Contributor
There was a problem hiding this comment.
Approved after testing. I created an account, went through the MFA setup, then started the account reset flow. I verified the job correctly expires reset requests by setting the cancelled_at timestamp and clearing both tokens. The analytics event is also being logged properly.
mdiarra3
reviewed
May 21, 2025
Contributor
There was a problem hiding this comment.
I think the first few runs of this will be super expensive / lots of items. should we set up a limit to the query initially so that we dont have an issue with this job failing if the amount is too large. maybe limit to 1000 for now
Contributor
Author
There was a problem hiding this comment.
added a limit to that query
kevinsmaster5
force-pushed
the
kmas-lg-16204-create-expire-account-reset-request-job
branch
from
d9a1063 to
f799266
Compare
mdiarra3
approved these changes
May 21, 2025
kevinsmaster5
deleted the
kmas-lg-16204-create-expire-account-reset-request-job
branch
vrajmohan
added a commit
that referenced
this pull request
May 31, 2025
…Notify Users (#12187)" This reverts commit cdd51a7. changelog: Bug Fixes, Account Deletion, Revert job that expires AccountResetRequests Requests were being cancelled a few minutes after AccountResetRequest.granted_at instead of after at least 1 day. See https://gsa-tts.slack.com/archives/C20J64X6V/p1748681101414939.
vrajmohan
added a commit
that referenced
this pull request
Jun 2, 2025
…Notify Users (#12187)" (#12224) This reverts commit cdd51a7. changelog: Bug Fixes, Account Deletion, Revert job that expires AccountResetRequests Requests were being cancelled a few minutes after AccountResetRequest.granted_at instead of after at least 1 day. See https://gsa-tts.slack.com/archives/C20J64X6V/p1748681101414939.
solipet
pushed a commit
that referenced
this pull request
Jun 2, 2025
…Notify Users (#12187)" (#12224) This reverts commit cdd51a7. changelog: Bug Fixes, Account Deletion, Revert job that expires AccountResetRequests Requests were being cancelled a few minutes after AccountResetRequest.granted_at instead of after at least 1 day. See https://gsa-tts.slack.com/archives/C20J64X6V/p1748681101414939.
solipet
added a commit
that referenced
this pull request
Jun 2, 2025
…Notify Users (#12187)" (#12224) (#12227) This reverts commit cdd51a7. changelog: Bug Fixes, Account Deletion, Revert job that expires AccountResetRequests Requests were being cancelled a few minutes after AccountResetRequest.granted_at instead of after at least 1 day. See https://gsa-tts.slack.com/archives/C20J64X6V/p1748681101414939. Co-authored-by: Vraj Mohan <vraj.mohan@gsa.gov>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16204
🛠 Summary of changes
Created a new worker job that looks for unexpired account deletion requests that have been created older than the
account_reset_token_valid_for_dayswindow and expires them logging the event.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
account_reset_token_valid_for_daysconfiguration:account_reset_request_expiredgets logged.