LG-16185 Turn on ft unlock upsell sms#12238

Merged

kevinsmaster5 merged 28 commits intomainfrom

LG-16185-kmas-turn-on-ft-unlock-upsell-sms-db-migrate

Jun 11, 2025

Commits on Jun 11, 2025

changelog: User-Facing Improvements, Face or Touch Unlock Adoption, Turn on FT unlock upsell to SMS users. Migration.
kevinsmaster5
committed
migrated schema
kevinsmaster5
committed
rename table and method
kevinsmaster5
committed
remove unneeded schema changes. add check for platform auth available and redirect
kevinsmaster5
committed
add delivery pref for sms, add test for controller changes
kevinsmaster5
committed
clean up unneeded saves
kevinsmaster5
committed
move redirect to app controller after sign in path
kevinsmaster5
committed
check for mfa selection flow
kevinsmaster5
committed
indentation
kevinsmaster5
committed
remove no-longer needed session key deletion
kevinsmaster5
committed
only qualify if user is on mobile
kevinsmaster5
committed
should not be in selection flow, also fix test lint
kevinsmaster5
committed
fix test by settinga dismissed at time for the user's webauthn_platform_dismissed_at
kevinsmaster5
committed
move dismissed_at to users factory
kevinsmaster5
committed
remove removed linebreaks
kevinsmaster5
committed
move to :with_phone
kevinsmaster5
committed
rely on sms setup value
kevinsmaster5
committed
fix check for sms setup
kevinsmaster5
committed
change dismissed at from db update
kevinsmaster5
committed
add dismissal update further downstream of test
kevinsmaster5
committed
back out of changes in 0c0be1c
kevinsmaster5
committed
merge funny business removed
kevinsmaster5
committed
further schema unwanted merge flack removed
kevinsmaster5
committed
optimize ordering of checks for upsell eligibility
kevinsmaster5
committed
refactor tests to avoid updating user db values
kevinsmaster5
committed
replace with click button on 'Skip'
kevinsmaster5
committed
remove unlikely needed button click
kevinsmaster5
committed
add in missing button click
kevinsmaster5
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-16185 Turn on ft unlock upsell sms#12238

LG-16185 Turn on ft unlock upsell sms#12238
kevinsmaster5 merged 28 commits intomainfrom
LG-16185-kmas-turn-on-ft-unlock-upsell-sms-db-migrate

Commits on Jun 11, 2025

changelog: User-Facing Improvements, Face or Touch Unlock Adoption, Turn on FT unlock upsell to SMS users. Migration.

migrated schema

rename table and method

remove unneeded schema changes. add check for platform auth available and redirect

add delivery pref for sms, add test for controller changes

clean up unneeded saves

move redirect to app controller after sign in path

check for mfa selection flow

indentation

remove no-longer needed session key deletion

only qualify if user is on mobile

should not be in selection flow, also fix test lint

fix test by settinga dismissed at time for the user's webauthn_platform_dismissed_at

move dismissed_at to users factory

remove removed linebreaks

move to :with_phone

rely on sms setup value

fix check for sms setup

change dismissed at from db update

add dismissal update further downstream of test

back out of changes in 0c0be1c

merge funny business removed

further schema unwanted merge flack removed

optimize ordering of checks for upsell eligibility

refactor tests to avoid updating user db values

replace with click button on 'Skip'

remove unlikely needed button click

add in missing button click