LG-16185 Turn on ft unlock upsell sms#12238
Merged
kevinsmaster5 merged 28 commits intomainfrom Jun 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
can ft be expanded? it wasn't immediately clear to me what it meant
Contributor
Author
There was a problem hiding this comment.
You're absolutely correct - I was about to rename that column but realized after talking to the team we can use the "webauthn_platform_recommended_dismissed_at" column that's already there.
kevinsmaster5
changed the title
kevinsmaster5
force-pushed
the
LG-16185-kmas-turn-on-ft-unlock-upsell-sms-db-migrate
branch
from
2b1b240 to
e784c72
Compare
jmdembe
reviewed
Jun 9, 2025
Contributor
There was a problem hiding this comment.
Can we do a check of if SMS is set up rather than use the params?
Contributor
Author
There was a problem hiding this comment.
That works! I have that added in.
kevinsmaster5
force-pushed
the
LG-16185-kmas-turn-on-ft-unlock-upsell-sms-db-migrate
branch
from
3710580 to
40feed4
Compare
Comment on lines
105
to
109
Contributor
There was a problem hiding this comment.
Suggested change
| user_session[:platform_authenticator_available] && | |
| !current_user.webauthn_platform_recommended_dismissed_at? && | |
| current_user.webauthn_configurations.where(platform_authenticator: [false, nil]) && | |
| phone_configuration.delivery_preference == 'sms' && | |
| mobile? | |
| user_session[:platform_authenticator_available] && | |
| !current_user.webauthn_platform_recommended_dismissed_at? && | |
| phone_configuration.delivery_preference == 'sms' && | |
| mobile? && | |
| current_user.webauthn_configurations.where(platform_authenticator: [false, nil]) |
Small suggestion to re-order the checks to make the most expensive ones last
mitchellhenke
approved these changes
Jun 11, 2025
…urn on FT unlock upsell to SMS users. Migration.
kevinsmaster5
force-pushed
the
LG-16185-kmas-turn-on-ft-unlock-upsell-sms-db-migrate
branch
from
3aebe63 to
d821f79
Compare
kevinsmaster5
deleted the
LG-16185-kmas-turn-on-ft-unlock-upsell-sms-db-migrate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15837
🛠 Summary of changes
Adds a route to the OtpVerificationController to send users to the suggest Platform Authenticator screen if they are capable of using one, are using SMS, and a mobile device and have not previously dismissed the suggested MFA screen.
📜 Testing Plan
prerequisite: using browser dev tools simulate a mobile device
Each of these factors are required to show the suggested screen