-
Notifications
You must be signed in to change notification settings - Fork 166
LG-16063: TMX Result handling account creation #12218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mdiarra3
merged 49 commits into
main
from
LG-16063-tmx-result-handling-account-creation
Jun 13, 2025
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
4e42470
changelog: Upcoming Features, Account Creation, Threatmetrix result
mdiarra3 eddcf24
add scheam
mdiarra3 b8e036f
profiling concern and device result
mdiarra3 5531b4d
update schema
mdiarra3 ee54017
add document type
mdiarra3 8a589c7
fix concern
mdiarra3 245988a
fix analytics events
mdiarra3 545f928
simplify returning device profiling result
mdiarra3 942ef86
changelog: Upcoming Features, Account Creation, Block failing Threatm…
mdiarra3 ec94491
update migration
mdiarra3 b79028e
changelog: Upcoming Features, Threatmetrix, add migration for threat …
mdiarra3 e3071f6
remove change thats not a migration
mdiarra3 5614991
fix migration
mdiarra3 637f57d
update result
mdiarra3 78ca77a
update schema
mdiarra3 9f3f71e
add ab test bucket for tmx processing
mdiarra3 49de3bc
delete element if has relation
mdiarra3 eb3d4e6
Merge remote-tracking branch 'origin/main' into LG-16063-tmx-result-h…
mdiarra3 bb3f5a0
do perform now
mdiarra3 41cf80d
update spec
mdiarra3 3988044
fix profiling result migration to remove index
mdiarra3 762e028
add translations for failure page
mdiarra3 af7f406
update set up concern to sign_up completed path
mdiarra3 e9eb27a
after sign in path update
mdiarra3 dbdd694
move to have session deleted
mdiarra3 a544aaa
Merge remote-tracking branch 'origin/main' into LG-16063-tmx-result-h…
mdiarra3 2a9c0f6
Merge remote-tracking branch 'origin/LG-16063-tmx-result-handling-acc…
mdiarra3 8e943a4
add resultsg
mdiarra3 6de7229
add profiling failed analytic event
mdiarra3 68aeddd
remove trailing whitespace
mdiarra3 3f8ed2a
fix schema
mdiarra3 fff0854
update tmx job
mdiarra3 8e57047
update
mdiarra3 d8e0f03
update features
mdiarra3 99879be
device profiling result
mdiarra3 72f526c
add mfa
mdiarra3 6b77e7c
fix threat metrix spec
mdiarra3 01ed27d
update job to be performed later
mdiarra3 6a337ae
Merge remote-tracking branch 'origin/main' into LG-16063-tmx-result-h…
mdiarra3 cdfcfc5
test commit
mdiarra3 e56db08
updated device profiling failed
mdiarra3 0df8777
update threat metrix specs and completions controller
mdiarra3 70af7ae
change path name in tmx spec
mdiarra3 9be67ec
update to be complete
mdiarra3 2f1a3ff
fix device profiling result
mdiarra3 813a16b
Merge remote-tracking branch 'origin/main' into LG-16063-tmx-result-h…
mdiarra3 3f2192a
account device profile rejected after authentication
mdiarra3 367a522
add check to session controller
mdiarra3 3c93f35
remove unused columns
mdiarra3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| class DeviceProfilingFailedController < ApplicationController | ||
| def show | ||
| analytics.device_profiling_failed_visited | ||
| sign_out | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <% self.title = t('profiling_failed.title') %> | ||
|
|
||
| <%= render AlertIconComponent.new(icon_name: :error, class: 'display-block margin-bottom-4') %> | ||
| <%= render PageHeadingComponent.new.with_content(t('profiling_failed.title')) %> | ||
| <p> | ||
| <%= t('profiling_failed.details') %> | ||
| </p> | ||
|
|
||
| <%= link_to( | ||
| root_url, | ||
| class: 'usa-button usa-button--big usa-button--wide', | ||
| ) { t('links.exit_login', app_name: APP_NAME) } %> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
db/primary_migrate/20250611195441_remove_unused_attributes_on_device_profile_result.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| class RemoveUnusedAttributesOnDeviceProfileResult < ActiveRecord::Migration[8.0] | ||
| def change | ||
| safety_assured do | ||
| remove_column :device_profiling_results, :reason | ||
| remove_column :device_profiling_results, :success | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear what
successvsreview_statusis inDeviceProfilingResult. Also, what is the difference betweenfailedandrejected?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
success Is simple of what we think is a success vs failure. But I think review_status is a little bit more involved/ in depth than the success attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
successcan be derived fromreview_status, we should only persistreview_statusand leavesuccessas a method on the model.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed success as well