LG-16063: TMX Result handling account creation#12218
Merged
Conversation
…metrix processing
…andling-account-creation
…andling-account-creation
…ount-creation-migration' into LG-16063-tmx-result-handling-account-creation
…andling-account-creation
vrajmohan
reviewed
Jun 6, 2025
vrajmohan
reviewed
Jun 6, 2025
vrajmohan
reviewed
Jun 6, 2025
| profiling_result = find_device_profiling_result( | ||
| DeviceProfilingResult::PROFILING_TYPES[:account_creation], | ||
| ) | ||
| profiling_result&.rejected? |
Contributor
There was a problem hiding this comment.
It is not clear what success vs review_status is in DeviceProfilingResult. Also, what is the difference between failed and rejected?
Contributor
Author
There was a problem hiding this comment.
success Is simple of what we think is a success vs failure. But I think review_status is a little bit more involved/ in depth than the success attribute.
Contributor
There was a problem hiding this comment.
If success can be derived from review_status, we should only persist review_status and leave success as a method on the model.
Contributor
Author
There was a problem hiding this comment.
removed success as well
vrajmohan
reviewed
Jun 6, 2025
vrajmohan
reviewed
Jun 6, 2025
vrajmohan
approved these changes
Jun 12, 2025
Contributor
vrajmohan
left a comment
vrajmohan
left a comment
There was a problem hiding this comment.
Looks good. I would suggest squashing all the commit messages so that they make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16063
🛠 Summary of changes
Initial processing of failed TMX results, for users that fail the DDP profiling=
📜 Testing Plan
account_creation_device_profilingconfig is set toenabledlexisnexis_threatmetrix_mock_enabledenabled totruereject