LG-15700 - Update mock proofer to handle passport YAML#12071
Merged
Conversation
changelog: Internal, Testing, Added support for passports to the Mock Proofer.
lmgeorge
reviewed
Apr 16, 2025
lmgeorge
approved these changes
Apr 16, 2025
Contributor
lmgeorge
left a comment
There was a problem hiding this comment.
I only have one change for documentation but otherwise LGTM. (caveat I did a read-only review for the sake of time)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15700
🛠 Summary of changes
Write a brief description of what you changed.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
passport_credential.ymlfrom thespec/fixturesdirectory.passport_bad_mrz_credential.yml