Skip to content

LG-16031: Send only first part of last name to AAMVA#12054

Merged
amirbey merged 6 commits intomainfrom
amirbey/margolis-aamva-multiple-last-name
Apr 4, 2025
Merged

LG-16031: Send only first part of last name to AAMVA#12054
amirbey merged 6 commits intomainfrom
amirbey/margolis-aamva-multiple-last-name

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Apr 4, 2025

🎫 Ticket

Link to the relevant ticket:
LG-16031

🛠 Summary of changes

Send only the first part of a last name that contains a space to states as configured.

📜 Testing Plan

  • Automated test of sending a last name with space to a stated configured to do so.

@amirbey amirbey self-assigned this Apr 4, 2025
end

describe 'compound last names' do
let(:applicant_data) { super().merge(last_name: 'McFirst McSecond') }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be preferable to turn the last name into a variable like we do for state_id_number and state_id_jurisdiction?

@amirbey amirbey marked this pull request as ready for review April 4, 2025 16:10
@amirbey amirbey requested review from mitchellhenke and solipet April 4, 2025 16:33
@amirbey amirbey changed the title Send only first part of last name to AAMVA for DC, WV (#12045) LG-16031: Send only first part of last name to AAMVA Apr 4, 2025
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zachmargolis and others added 6 commits April 4, 2025 13:49
* Send only first part of last name to AAMVA for DC, WV

**Why**: Apparently the backend processors for DC and WV only process matches
up to the first "word" of a last name

* fixup: use correct let()

* Update reference to last_name
changelog: Bug Fixes, Identity Proofing, Split last names with space configurable opt-in by AAMVA state
@amirbey amirbey force-pushed the amirbey/margolis-aamva-multiple-last-name branch from 0354ffb to 871a3e3 Compare April 4, 2025 17:49
@amirbey amirbey merged commit a82e785 into main Apr 4, 2025
1 check passed
@amirbey amirbey deleted the amirbey/margolis-aamva-multiple-last-name branch April 4, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants