Send only first part of last name to AAMVA for DC, WV#12045
Merged
amirbey merged 3 commits into18F:amirbey/margolis-aamva-multiple-last-namefrom Apr 4, 2025
Merged
Conversation
**Why**: Apparently the backend processors for DC and WV only process matches up to the first "word" of a last name
|
|
Contributor
Author
|
@amirbey Ran into the issue with my DC license as I have two last names with a space in between. I sent you the associated email address via DM. |
amirbey
changed the base branch from
main
to
amirbey/margolis-aamva-multiple-last-name
amirbey
approved these changes
Apr 4, 2025
amirbey
pushed a commit
that referenced
this pull request
Apr 4, 2025
* Send only first part of last name to AAMVA for DC, WV **Why**: Apparently the backend processors for DC and WV only process matches up to the first "word" of a last name * fixup: use correct let() * Update reference to last_name
amirbey
added a commit
that referenced
this pull request
Apr 4, 2025
* Send only first part of last name to AAMVA for DC, WV (#12045) * Send only first part of last name to AAMVA for DC, WV **Why**: Apparently the backend processors for DC and WV only process matches up to the first "word" of a last name * fixup: use correct let() * Update reference to last_name * make split last name opt-in configurable by state changelog: Bug Fixes, Identity Proofing, Split last names with space configurable opt-in by AAMVA state * add last_name_spaced to analytics for proofing results * add last_name_spaced to signatur of profing analytics event * happy linting * update last_name in spec --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
|
Confirmed, reviewed and accepted. This should be out tomorrow afternoon, @zachmargolis. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 hi friends, it's been a while!
Background
My new job also works with AAMVA, and a colleague let me know about a new bug he discovered. For DC and WV apparently the backend processors for only process matches up to the first "word" of a last name. So for a user whose last name is "McFirst McSecond", we need to send "McFirst" only to get a match in those states. It's undocumented and discovered through customer data.
🛠 Summary of changes
Updates
Aamva::VerificationRequestto only send the first part of last names in DC and WV📜 Testing Plan
Provide a checklist of steps to confirm the changes.
last_name.split(' ').firstis sent as the last nameaamva_test.rbidentity-idp/lib/aamva_test.rb
Line 27 in 0e6cfb3