Skip to content

Update saml_idp gem #11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Feb 12, 2025
Merged

Update saml_idp gem #11873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ gem 'rqrcode'
gem 'ruby-progressbar'
gem 'ruby-saml'
gem 'safe_target_blank', '>= 1.0.2'
gem 'saml_idp', github: '18F/saml_idp', tag: '0.23.5-18f'
gem 'saml_idp', github: '18F/saml_idp', tag: '0.23.6-18f'
gem 'scrypt'
gem 'simple_form', '>= 5.0.2'
gem 'stringex', require: false
Expand Down
7 changes: 4 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,15 @@ GIT

GIT
remote: https://github.com/18F/saml_idp.git
revision: bdf8e1f93707e413ecbd0f48d803e18812e19f90
tag: 0.23.5-18f
revision: 32e9be98c30bc5d01b4088500e4d518f724aadc5
tag: 0.23.6-18f
specs:
saml_idp (0.23.5.pre.18f)
saml_idp (0.23.6.pre.18f)
activesupport
builder
faraday
nokogiri (>= 1.10.2)
ostruct
Copy link
Copy Markdown
Contributor Author

@zachmargolis zachmargolis Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this wasn't a new add overall for the ostruct gem, we already had it, so I'm wondering if the warning was already taken care of? Or this won't affect it?

Copy link
Copy Markdown
Contributor

@Sgtpluck Sgtpluck Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe? but i bet we need it for the dashboard app, so it's a worthwhile change

Copy link
Copy Markdown
Contributor Author

@zachmargolis zachmargolis Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm ok well we added as an explicit dependecy in https://github.com/18F/identity-idp/pull/11605/files#diff-89cade48462044ee1b672dc5f4c3ec250fbd29effcd8932096a23c1283c6731fR472, but hopefully this helps squash the warning!

Copy link
Copy Markdown
Contributor

@mitchellhenke mitchellhenke Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it due to ostruct previously only being a dependency of test/dev dependencies?

Copy link
Copy Markdown
Contributor Author

@zachmargolis zachmargolis Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh maybe that's it!

pkcs11

GIT
Expand Down